[mogretici]

Summary:

On the New Architecture, a View's onMagicTap handler never runs on iOS. A VoiceOver two-finger double tap on the view does nothing.

The cause is a prop-name mismatch:

• JS registers the listener as onMagicTap. See Libraries/Components/View/ViewPropTypes.js and Libraries/NativeComponent/BaseViewConfig.ios.js, where topMagicTap has registrationName: 'onMagicTap' and validAttributes contains onMagicTap: true. So the raw prop that reaches Fabric is onMagicTap.
• AccessibilityProps reads the flag from onAccessibilityMagicTap instead, both in the constructor (convertRawProp(..., "onAccessibilityMagicTap", ...)) and in setProp (RAW_SET_PROP_SWITCH_CASE_BASIC(onAccessibilityMagicTap), which keys on the field name). As a result onAccessibilityMagicTap stays false.
• RCTViewComponentView's accessibilityPerformMagicTap checks _props->onAccessibilityMagicTap, so it always returns NO, and the event emitter's onAccessibilityMagicTap() is never called.

The legacy renderer is not affected: RCTViewManager remaps onMagicTap directly. The sibling props (onAccessibilityTap, onAccessibilityEscape, onAccessibilityAction) already use matching names.

This change reads the flag from onMagicTap in both parsing paths. The C++ field name and the event emitter are unchanged.

Changelog:

[IOS] [FIXED] - onMagicTap now fires for VoiceOver's magic tap on the New Architecture

Test Plan:

• Added AccessibilityPropsTest.reads_magic_tap_listener_from_on_magic_tap. It parses { onMagicTap: true } through ViewProps, the same way the existing tests in that file do, and expects onAccessibilityMagicTap to be true. Without this change the flag is false. I could not run the ReactCommon gtest suite locally; it isn't wired into the OSS CI.
• I traced the mismatch on main (0941e95) and on the v0.86.3, v0.87.0 and v0.88.0 tags; all four have the same code.
• I found it while wiring onMagicTap in an app on RN 0.86.3 (Expo SDK 57, New Architecture) and confirmed it by following the code path above. I have not verified the fix on a device, because that app uses the prebuilt RN core.

[meta-cla]

Hi @mogretici!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[meta-cla]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[meta-cla]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!