Repository navigation
Conversation
Summary: The `flow strict` annotation was accidently removed in D74574293. This diff brings it back and fixes flow errors caused by this change. This makes generated TS types for `composeStyles` more relaxed but the main idea of inferring inputs base on output type annotation is preserved. Changelog: [Internal] Reviewed By: huntie Differential Revision: D75945388
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75945388 |
facebook-github-bot
added
p: Software Mansion
Contributor
|
This pull request has been merged in 0de92b5. |
Collaborator
|
This pull request was successfully merged by @coado in 0de92b5 When will my fix make it into a release? | How to file a pick request? |
jbroma
pushed a commit
to jbroma/react-native
that referenced
this pull request
Jun 4, 2025
…#51103) Summary: Fixes react#51083. Turbo stripped out the dictionary when the value is null. The old architecture transforms null to NSNull. The null seems useful in cases like react#51803 for removing the storage of the key. cipolleschi can you please help to review? ## Changelog: [IOS] [FIXED] - Turbo module: Fixes dictionary stripped out when value is null Pull Request resolved: react#51103 Test Plan: Repro please see react#51083. Reviewed By: rshest Differential Revision: D74208525 Pulled By: javache fbshipit-source-id: 53d630c265fba15d25309a3e1deb19dca24f298c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
flow strictannotation was accidently removed in D74574293. This diff brings it back and fixes flow errors caused by this change. This makes generated TS types forcomposeStylesmore relaxed but the main idea of inferring inputs base on output type annotation is preserved.Changelog:
[Internal]
Reviewed By: huntie
Differential Revision: D75945388