Skip to content

Disable enableModuleArgumentNSNullConversionIOS by default #51576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javache wants to merge 1 commit into from
Closed

Disable enableModuleArgumentNSNullConversionIOS by default #51576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<fcee66a9800d5b3b1105df73d33feea9>>
* @generated SignedSource<<07ea15d4fd3f3bc73c8f49cd24724caf>>
*/

/**
Expand Down Expand Up @@ -71,7 +71,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

override fun enableMainQueueModulesOnIOS(): Boolean = false

override fun enableModuleArgumentNSNullConversionIOS(): Boolean = true
override fun enableModuleArgumentNSNullConversionIOS(): Boolean = false

override fun enableNativeCSSParsing(): Boolean = false

Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<c80be05a320b2cb0e78865492f503922>>
* @generated SignedSource<<6692978a1497fa9e99d539511388c9fa>>
*/

/**
Expand Down Expand Up @@ -124,7 +124,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
}

bool enableModuleArgumentNSNullConversionIOS() override {
return true;
return false;
}

bool enableNativeCSSParsing() override {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ const definitions: FeatureFlagDefinitions = {
ossReleaseStage: 'none',
},
enableModuleArgumentNSNullConversionIOS: {
defaultValue: true,
defaultValue: false,
metadata: {
description:
'Enable NSNull conversion when handling module arguments on iOS',
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<cbcc6da9a0d0652dddd99977690a258a>>
* @generated SignedSource<<4d96a5f9132ea827faeb183fe8bbf095>>
* @flow strict
* @noformat
*/
Expand Down Expand Up @@ -281,7 +281,7 @@ export const enableMainQueueModulesOnIOS: Getter<boolean> = createNativeFlagGett
/**
* Enable NSNull conversion when handling module arguments on iOS
*/
export const enableModuleArgumentNSNullConversionIOS: Getter<boolean> = createNativeFlagGetter('enableModuleArgumentNSNullConversionIOS', true);
export const enableModuleArgumentNSNullConversionIOS: Getter<boolean> = createNativeFlagGetter('enableModuleArgumentNSNullConversionIOS', false);
/**
* Parse CSS strings using the Fabric CSS parser instead of ViewConfig processing
*/
Expand Down