Skip to content

Add unit test for NSNull behaviour in RCTTurboModule - #51370

Closed
javache wants to merge 2 commits into
react:mainfrom
javache:export-D74815079
Closed

javache wants to merge 2 commits into
react:mainfrom
javache:export-D74815079

Conversation

@javache

@javache javache commented May 15, 2025 •

Copy link
Copy Markdown
Contributor

Changelog: [Internal]

Differential Revision: D74815079

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 15, 2025
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74815079

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74815079

@javache
javache force-pushed the export-D74815079 branch from 9ebd2de to 6d9887b Compare May 15, 2025 17:50
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74815079

javache added 2 commits May 16, 2025 06:20
…elector (react#51366)

Summary:

We inherited this from the legacy native module infra, where we didn't have access to the module instance. Instead we can use the simpler `methodSignatureForSelector` which works correctly with OCMock (needed in D74815079).

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D74817191
Summary:
Changelog: [Internal]


Reviewed By: NickGerleman

Differential Revision: D74815079
@javache
javache force-pushed the export-D74815079 branch from 6d9887b to ce9d097 Compare May 16, 2025 13:21
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74815079

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 16, 2025
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in 6d25274.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants