use_framework! + hermes enable = Undefined symbols "vtable for facebook::react::HermesExecutorFactory"

Description

Hi guys,

I'm trying to use hermes with use_framework!.

I was on 0.66.4, with hermes disabled and use_framework enabled. My app was working great, but on some Android device i got a crash from JSC so we decided to enable hermes.
I tried to use both hermes and use_framework but it don't work. After some research i understand i have to upgrade RN to 0.69.3.
After Upgrade i got an issue wich was fixed by this PR :88b7b64
I patched react-native to integrate this PR

After the patch i got another issue:

Undefined symbols for architecture x86_64:
"vtable for facebook::react::HermesExecutorFactory", referenced from:
facebook::react::HermesExecutorFactory::HermesExecutorFactory(std::__1::function<void (facebook::jsi::Runtime&)>, std::__1::function<void (std::__1::function<void ()> const&, std::__1::function<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > ()>)> const&, hermes::vm::RuntimeConfig) in RCTCxxBridge.o
NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Someone know how i can fix this issue ? Cause for now, i can't use hermes and use_framework together on all version of RN

Version

0.69.3

Output of `npx react-native info`

System:
OS: macOS 12.0.1
CPU: (10) x64 Apple M1 Pro
Memory: 135.61 MB / 32.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 14.17.0 - ~/.nvm/versions/node/v14.17.0/bin/node
Yarn: 1.22.17 - ~/.nvm/versions/node/v14.17.0/bin/yarn
npm: 6.14.13 - ~/.nvm/versions/node/v14.17.0/bin/npm
Watchman: 2022.05.16.00 - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.10.2 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 15.4, macOS 12.3, tvOS 15.4, watchOS 8.5
Android SDK: Not Found
IDEs:
Android Studio: 2020.3 AI-203.7717.56.2031.7935034
Xcode: 13.3.1/13E500a - /usr/bin/xcodebuild
Languages:
Java: 11.0.11 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.0.0 => 18.0.0
react-native: 0.69.3 => 0.69.3
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found

Steps to reproduce

Upgrade RN from 0.66.4 -> 0.69.3
Patch RN with : 88b7b64
Enable Hermes
Enable use_framework

Snack, code example, screenshot, or link to a repository

@neildhar

I'm trying to use hermes with use_framework!.

I don't think Hermes currently supports use_framework. @dmitryrykun @neildhar @Kudo and other folks might have more context than me on this.

It is fixed here: 79baca6
It is in the main branch and in 0.70.0-rc.2, but not in 0.69.3

still happens on 0.70

@lightrow

@lightrow could you share more details? it works for me on a blank 0.70 project.

@lightrow

@lightrow could you share more details? it works for me on a blank 0.70 project.

ah i just realized it's slightly different

Undefined symbols for architecture arm64:
  "vtable for facebook::react::HermesExecutorFactory", referenced from:
      facebook::react::HermesExecutorFactory::HermesExecutorFactory(std::__1::function<void (facebook::jsi::Runtime&)>, std::__1::function<void (std::__1::function<void ()> const&, std::__1::function<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > ()>)> const&, hermes::vm::RuntimeConfig) in RCTCxxBridge.o
  NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

arm64 instead of x86_64. I have an M1

I also have this problem (without an M1 and with architecture x86_64)
Fabric is disabled
Flipper is disabled (won't work with use_framework anyway)
Derived data and build folder are clean
XCode 13.4.1

System:
    OS: macOS 12.5.1
    CPU: (8) x64 Intel(R) Core(TM) i7-1068NG7 CPU @ 2.30GHz
    Memory: 1.64 GB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.15.0 - ~/Library/Caches/fnm_multishells/40339_1662544747645/bin/node
    Yarn: 1.22.18 - ~/Library/Caches/fnm_multishells/40339_1662544747645/bin/yarn
    npm: 8.5.5 - ~/Library/Caches/fnm_multishells/40339_1662544747645/bin/npm
    Watchman: 2022.02.28.00 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.11.2 - /Users/louislagrange/.rvm/gems/ruby-2.7.2/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
    Android SDK:
      API Levels: 28, 29, 30, 31, 32, 33
      Build Tools: 28.0.3, 29.0.2, 29.0.3, 30.0.2, 30.0.3, 31.0.0, 32.0.0, 32.1.0
      System Images: android-31 | Google Play Intel x86 Atom_64, android-33 | Google Play Intel x86 Atom_64
      Android NDK: Not Found
  IDEs:
    Android Studio: Chipmunk 2021.2.1 Patch 2 Chipmunk 2021.2.1 Patch 2
    Xcode: 13.4.1/13F100 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.12 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.1.0 => 18.1.0 
    react-native: 0.70.0 => 0.70.0 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

I also just tested with an empty project, only added use_frameworks! to Podfile and got the same error

arch -x86_64 pod install and running Xcode with Rosetta results in the same error with x86_64 instead of arm64

I have this issue too in my Intel Mac. I have never been able to build for iOS with Hermes enabled. 0.70.0 did not change this.

Undefined symbols for architecture arm64:
  "vtable for facebook::react::HermesExecutorFactory", referenced from:
      facebook::react::HermesExecutorFactory::HermesExecutorFactory(std::__1::function<void (facebook::jsi::Runtime&)>, std::__1::function<void (std::__1::function<void ()> const&, std::__1::function<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > ()>)> const&, hermes::vm::RuntimeConfig) in RCTCxxBridge.o
  NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Experiencing this too:

Undefined symbols for architecture x86_64:
  "vtable for facebook::react::HermesExecutorFactory", referenced from:
      facebook::react::HermesExecutorFactory::HermesExecutorFactory(std::__1::function<void (facebook::jsi::Runtime&)>, std::__1::function<void (std::__1::function<void ()> const&, std::__1::function<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > ()>)> const&, hermes::vm::RuntimeConfig) in RCTCxxBridge.o
  NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

/Users/ramiel/Desktop/Typescript/reactNative/Notifications/ios/Pods/Pods.xcodeproj: warning: MobileCoreServices has been renamed. Use CoreServices instead. (in target 'React-RCTNetwork' from project 'Pods')

2022-09-13 10:06:41.363 xcodebuild[3447:3681217] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionSentinelHostApplications for extension Xcode.DebuggerFoundation.AppExtensionHosts.watchOS of plug-in com.apple.dt.IDEWatchSupportCore
2022-09-13 10:06:41.364 xcodebuild[3447:3681217] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionPointIdentifierToBundleIdentifier for extension Xcode.DebuggerFoundation.AppExtensionToBundleIdentifierMap.watchOS of plug-in com.apple.dt.IDEWatchSupportCore
** BUILD FAILED **


The following build commands failed:
	Ld /Users/ramiel/Library/Developer/Xcode/DerivedData/Notifications-dclqlkvlkajkvcdnlodvgezguaav/Build/Products/Debug-iphonesimulator/React-Core/React.framework/React normal (in target 'React-Core' from project 'Pods')
(1 failure)

I think we must use frameworks like this

use_frameworks! :linkage => :static

In my case, I am using Firebase, and with react-native 0.70 and Firebase v9+ the docs advised to use this way.

I think we must use frameworks like this

use_frameworks! :linkage => :static

In my case, I am using Firebase, and with react-native 0.70 and Firebase v9+ the docs advised to use this way.

This solved my issue
use_frameworks! :linkage => :static

and commented out
:flipper_configuration => FlipperConfiguration.enabled,

1- use_frameworks! :linkage => :static (inside target 'projectName' do)
2- disabled :flipper_configuration => FlipperConfiguration.enabled
3- add s.dependency "React-hermes", version in side /node_modules/react-native/React-Core.podspec

works for me in Recat Native 0.70.6

im also facing this issue in rn-0.70.2
tried below steps

1- use_frameworks! :linkage => :static (inside target 'projectName' do) 2- disabled :flipper_configuration => FlipperConfiguration.enabled 3- add s.dependency "React-hermes", version in side /node_modules/react-native/React-Core.podspec

works for me in Recat Native 0.70.6

same error
The following build commands failed: Ld /Users/user/Library/Developer/Xcode/DerivedData/Elnashra-hjdnhtbsafvjvofifgzvhxjxpzcd/Build/Products/Debug-iphonesimulator/React-Core/React.framework/React normal (1 failure)
what can i do ?

use_frameworks! :linkage => :static

Thank you, it works! on 0.70.6

Adding this fixed it for me

For those who can't use use_frameworks! :linkage => :static, you can manually convert only react-specific libraries by doing:

use_frameworks!

$static_framework = [ 'YogaKit', 'RCT-Folly', 'RCTTypeSafety', 'ReactCommon']
  pre_install do |installer|
    Pod::Installer::Xcode::TargetValidator.send(:define_method, :verify_no_static_framework_transitive_dependencies) {}
  
    installer.pod_targets.each do |pod|
      if pod.name.start_with?('React-') || $static_framework.include?(pod.name)
        def pod.build_type;
          # Uncomment the line corresponding to your CocoaPods version
          # Pod::BuildType.static_library # >= 1.9
          # Pod::Target::BuildType.static_library # < 1.9
        end
      end
    end
  end

You can also add other frameworks/libraries to the $static_framework list to convert it as well.
Tested on RN 0.70.6.

@Jichao

Thank you. @Jichao
Saved my week's work.

this worked
add
s.dependency "React-hermes", version
to react-core.podspec

and remove static linkage from your pod file

@Mrezagolbaba

@Mrezagolbaba This makes the build progress, but still fails with ld: 98 duplicate symbols for architecture arm64. I installed the default RN repo, ran it successfully, went for a walk, and by the time I came back the project no longer built with the issues above.

I have the same problem:

818 duplicate symbols for architecture arm64 on my project.

I'm not sure how to fix it, but I've been running around in circles for a few days now :/

I've put the line use_frameworks in my podfile! :linkage => :static and I activated hermes

Thank you !

I think we must use frameworks like this

use_frameworks! :linkage => :static

In my case, I am using Firebase, and with react-native 0.70 and Firebase v9+ the docs advised to use this way.

nice, it saved me... thank you

React-native: 0.72.0
@react-native-firebase/app: 18.1.0

I had the same issue. I cleaned my IOS build folder in Xcode (Product -> Clean Build folder)

Then I added the following line in multiple files;

s.dependency 'React-hermes', version
node_modules/react-native/RNReanimated.podsec ,
node_modules/react-native/React.podspec,
node_modules/react-native-reanimated/React-Core.podspec

I changed the following in the Podfile:

    :hermes_enabled => true,
    :fabric_enabled => false,
    # :flipper_configuration => flipper_config,
    use_frameworks! :linkage => :static

If you are upgrading your react native version this repo might help you. This maintainer has a repo with the release versions for a basic react native application, the branches shows the release version:
https://github.com/react-native-community/rn-diff-purge/tree/release/0.72.0
Or if you would like to compare the changes you can use this website;
https://react-native-community.github.io/upgrade-helper/

Hope it helped someone :)

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

This issue was closed because it has been stalled for 7 days with no activity.

Navigation Menu

Repository navigation

use_framework! + hermes enable = Undefined symbols "vtable for facebook::react::HermesExecutorFactory" #34344

Description

Version

Output of `npx react-native info`

Steps to reproduce

Snack, code example, screenshot, or link to a repository

21 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

use_framework! + hermes enable = Undefined symbols "vtable for facebook::react::HermesExecutorFactory" #34344

Description

Description

Version

Output of npx react-native info

Steps to reproduce

Snack, code example, screenshot, or link to a repository

Activity

cortinico commented on Aug 5, 2022

dmytrorykun commented on Aug 5, 2022

lightrow commented on Sep 6, 2022

Kudo commented on Sep 7, 2022

lightrow commented on Sep 7, 2022

Minishlink commented on Sep 7, 2022

lightrow commented on Sep 7, 2022

tapz commented on Sep 10, 2022

itsramiel commented on Sep 13, 2022

mmelk commented on Sep 15, 2022

Hugyn commented on Oct 1, 2022

21 remaining items

Mrezagolbaba commented on Dec 5, 2022

sudharsanvishnu commented on Dec 6, 2022

YAMMOUNII commented on Dec 14, 2022

acro5piano commented on Dec 19, 2022

nandha-kumar-hajari commented on Dec 20, 2022

douugdev commented on Jan 18, 2023

Shubhambhagatofficial commented on Jan 24, 2023

MarinaAmy commented on Feb 3, 2023

paulopgss commented on Feb 12, 2023

bartkoedijk commented on Jun 26, 2023

github-actions commented on Jan 14, 2024

github-actions commented on Feb 5, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Output of `npx react-native info`