RCTRenderingPerf does not expose ReactPerf.printExclusive() #13608
Description
Description
When calling RCTRenderingPerf.stop, we automatically get the output from ReactPerf.printInclusive() and ReactPerf.printWasted(), but have no way of getting ReactPerf.printExclusive(), as it is not exposed by the module.
Reproduction Steps and Sample Code
The following code will trigger the output from printInclusive and printWasted:
import PerfMonitor from 'react-native/Libraries/Performance/RCTRenderingPerf'
PerfMonitor.toggle()
PerfMonitor.start()
setTimeout(() => {
PerfMonitor.stop()
}, 1000)
Solution
Expose the output functions to be called directly instead of automatically calling some inside stop.
import PerfMonitor from 'react-native/Libraries/Performance/RCTRenderingPerf'
PerfMonitor.toggle()
PerfMonitor.start()
setTimeout(() => {
PerfMonitor.stop()
PerfMonitor.printExclusive()
PerfMonitor.printInclusive()
PerfMonitor.printWasted()
}, 1000)
I am happy to do a merge request for this.
Additional Information
- React Native version: 0.43.3
Activity
hramos commentedon Jul 20, 2017
Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!
If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:
If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.