Skip to content

fix part of #3: created seperate css file for explore page - #38

Merged
flyingcircle merged 4 commits into
react-native-elements:masterfrom
nlok5923:fix
Dec 23, 2021
Merged

flyingcircle merged 4 commits into
react-native-elements:masterfrom
nlok5923:fix

Conversation

@nlok5923

Copy link
Copy Markdown
Contributor

Refers: #3

Changes:

  • made seperate css file for explore page.

@netlify

netlify Bot commented Mar 12, 2021 •

Copy link
Copy Markdown

Deploy preview for rne-playground ready!

Built with commit 661f556

https://deploy-preview-38--rne-playground.netlify.app

@tewarig tewarig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.. but this pull request is using a different version of few packages than the one used in this repo.

Comment thread src/pages/explore/Explore.module.css Resolved
@nlok5923

Copy link
Copy Markdown
Contributor Author

@pranshuchittora sir please review this pr.

@pranshuchittora pranshuchittora left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls, rename the class names. Position suffix is not intuitive.

@pranshuchittora

Copy link
Copy Markdown
Member

Pls pull the new changes

@nlok5923

Copy link
Copy Markdown
Contributor Author

@pranshuchittora sir please review this pr.

@flyingcircle
flyingcircle merged commit f579fe3 into react-native-elements:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants