Repository navigation
feat: add a command to download the Hermes Sampling Profiler to a local machine - #1246
Merged
Merged
Conversation
Implemented command to download the Hermes Sampling Profiler to a local machine
Integrated transformer tool into CLI
…eat/generate-source-map
Feat/generate source map
implemented @todo get only the .cpuprofile from cache/ add a few verbose logs edited profile-hermes.md
add the usage to commands.md delete the profile-hermes.md
thymikee
added a commit
to imoans/cli
that referenced
this pull request
Sep 17, 2020
* origin/master: (47 commits) chore(breaking): use Node 10 as compile target (react-native-community#1072) chore(deps): bump node-fetch from 2.6.0 to 2.6.1 (react-native-community#1267) v4.13.0 chore: remove await in getLatestFile function call from downloadProfile file. (react-native-community#1266) Augment react-native info with out of tree platform packages info (react-native-community#1264) feat: add a command to download the Hermes Sampling Profiler to a local machine (react-native-community#1246) chore(deps): bump lodash from 4.17.15 to 4.17.19 (react-native-community#1221) Fix package name for main activity when appId set (react-native-community#1242) Just use the users default browser (react-native-community#1257) feat: improve progress indicator for iOS builds without xcpretty (react-native-community#1254) fix: 🐛 executableFolderPath to run app name in iOS 14.0 (react-native-community#1236) chore(deps): bump elliptic from 6.5.2 to 6.5.3 (react-native-community#1233) v4.12.0 Add Windows info to react-native info (react-native-community#1227) add new version RN Podfile link, autolinking docs. (react-native-community#1245) docs: add linkage instructions for `yarn` v2 (react-native-community#1237) v4.11.0 fix: adjust range on react-native peer dep to support 0.63 (react-native-community#1234) chore: update jest config (react-native-community#1241) Use new chrome based edge if the user is already running it, and not running chrome (react-native-community#1222) ...
30 of 36 tasks
This was referenced Mar 13, 2021
Closed
Closed
Bump react-native from 0.63.4 to 0.64.0 in /react-native/ReactNativeFlipperExample
meta/flipper#2064
Closed
Closed
Closed
Closed
Closed
Closed
Contributor
|
is there no Would really be nice to have this included: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR implements a new command to download the Hermes Sampling Profiler to a local machine.
This command is built as part of the goal to visualize the performance of JavaScript running on Hermes in a React Native app.
@saphal1998 and I worked on this under @axemclion and @jevakallio guidance.
1. Purpose:
2. Usage:
destinationDiris optional; if provided, pull the file to that directoryOptions
--filename [string]File name of the profile to be downloaded, ex. sampling-profiler-trace8593107139682635366.cpuprofile
--verboseLists commands and steps that are run internally to pull the file from Android device
--rawPulls the original Hermes tracing profile without any transformation
--sourcemap-path [string]The local path to your source map file if you generated it manually, ex.
/tmp/sourcemap.json--generate-sourcemapGenerate the JS bundle and source map in
os.tmpdir()Notes on source map
If you are planning on building a debug APK, that will run without the packager, by invoking
./gradlew assembleDebugyou can simply setbundleInDebug: truein your app/build.gradle file, inside theproject.ext.reactmap.Test Plan:
yarnyarn lintreact-native profile-hermesas per instruction aboveExample output of running the command