Repository navigation
fix: classify stable releases using stable tags - #111
Merged
Merged
Conversation
| return 'live-update'; | ||
| } | ||
|
|
||
| export function assertUnusedStoreBuild(buildNumber, handoffs) { |
Contributor
There was a problem hiding this comment.
🟡 新規公開関数の必須JSDoc欠落
追加された公開関数 assertUnusedStoreBuild にJSDocがありません。変更時の必須規約が求める、すべての公開関数へのJSDoc付与に違反しています。
Suggested change
| export function assertUnusedStoreBuild(buildNumber, handoffs) { | |
| /** ストア配信のビルド番号が、過去のすべての引き渡し済みビルド番号を上回ることを検証する。 */ | |
| export function assertUnusedStoreBuild(buildNumber, handoffs) { |
Was this helpful? React with 👍 or 👎 to provide feedback.
npm beta packages publishedCI passed for the merge commit npm install @rdlabo/ionic-angular-kit@22.0.7-beta.pr111.sha5d3e06b75932 @rdlabo/ionic-angular-photo-editor@22.0.7-beta.pr111.sha5d3e06b75932 @rdlabo/ionic-angular-scroll-header@22.0.7-beta.pr111.sha5d3e06b75932 @rdlabo/ngx-cdk-scroll-strategies@22.0.7-beta.pr111.sha5d3e06b75932 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
正式版の分類には直前の正式タグを使います。新しいmajor/minorのプレリリース後に正式版を出す場合も、ストア配信として判定できます。
正式ストア配信では、同系列のCapawesome引き渡しタグから過去のネイティブビルド番号も確認し、使用済みの番号以下を拒否します。既存のAction出力は維持します。
検証
npm run test:actions50件通過取り込み後、Seatkeep #246、tipsys #314、receptray #104、foodlabel #310 で固定SHAへ切り替え、重複する分類・番号検査を削ります。