Repository navigation
Make it possible to use YAML data in lessons + 3.7/mac/Windows CI - #6
Merged
Merged
Conversation
encukou
added a commit
to encukou/naucse.python.cz
that referenced
this pull request
Feb 8, 2019
Takes the task definitions in YAML/Markdown from the Courseware (https://github.com/messa/pyladies-courseware) and renders them in HTML. Further homework can be added similarly. --- WIP: Requires naucse_render 1.1+ with merged pull request: pyvec/naucse_render#6 (Should be merged & released before merging this.) Run "pipenv install" to update.
Member
Author
|
PyLadiesCZ/naucse.python.cz#21 shows the intended usage. |
With this, we can keep structured info about tasks in YAML, but render them as a regular lesson.
encukou
changed the title
Member
Author
|
I've added two commits that:
I put them in the same PR because they'd conflict if I rebased them onto master. But if they're not good, the first two commits can be merged separately. |
hroncok
previously approved these changes
Feb 11, 2019
hroncok
left a comment
hroncok
left a comment
Member
There was a problem hiding this comment.
If this is time critical, ship at will and answer my questions later ;)
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this, we can keep structured info about tasks in YAML, but render them as a regular lesson.
This means we can use courseware task definitions and stick them in HTML.
Of course, in the future, structured data on tasks should be added to the API.
I'll follow up with a
pyladies/naucse.python.czPR for testing.