Activity

1. ilevkivskyi

   added

   bug

   on Jun 20, 2019
2. uriyyo commented on Aug 2, 2021

   

   uriyyo

   on Aug 2, 2021

   Member

   More actions

   This issue is fixed by python/cpython#27545
3. hauntsaninja

   closed this as completedon Aug 2, 2021
4. RamiAwar commented on Feb 24, 2024

   

   RamiAwar

   on Feb 24, 2024

   More actions

   Still getting this in Python 3.12 I believe. When I define an empty init in the class inheriting from the protocol my issues are solved. And they are only caused if I inherit from a Protocol.

   Maybe it's linked to the fact that I'm using a generic Protocol but I wouldn't know much about this.

   ...
   
   # Generic types per repository
   Model = TypeVar("Model", bound=DbBaseModel)
   TCreate = TypeVar("TCreate", bound=BaseModel, contravariant=True)
   TUpdate = TypeVar("TUpdate", bound=BaseModel, contravariant=True)
   
   # Only used as input
   ModelSchema = TypeVar("ModelSchema", bound=BaseModel)
   Data = TypeVar("Data", bound=BaseModel)
   
   
   class RepositoryProtocol(Protocol[Model, TCreate, TUpdate]):
       @property
       def model(self) -> Type[Model]: ...

   class BaseRepository(ABC, RepositoryProtocol[Model, TCreate, TUpdate]):
   
       @property
       @abstractmethod
       def model(self) -> Type[Model]:
           raise NotImplementedError

   I noticed this as I was using BaseRepository as a dependency in a FastAPI route. As soon as I added the protocol, the route was expecting *args, *kwargs as required arguments.

   As soon as I remove the protocol, this is fixed again.
   When I kept the Protocol but defined an empty init in BaseRepository, it was also fixed.

       def __init__(self) -> None: ...