Repository navigation
csv: annotate keyword arguments in various functions and methods - #7788
Merged
Merged
Conversation
AlexWaygood
commented
May 6, 2022
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
AlexWaygood
commented
May 6, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AlexWaygood
changed the title
csv module stubscsv: annotate **kwargs in various methods
AlexWaygood
changed the title
csv: annotate **kwargs in various methodscsv: annotate keyword arguments in various methods
AlexWaygood
marked this pull request as ready for review
May 7, 2022 11:31
AlexWaygood
changed the title
csv: annotate keyword arguments in various methodscsv: annotate keyword arguments in various functions and methods
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JelleZijlstra
approved these changes
May 8, 2022
JelleZijlstra
left a comment
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
This is correct, but while reviewing I noticed that our stubs for Dialect are wrong. I'll try to address that separately.
Member
Author
It doesn't seem like our csv stubs have had much TLC in a while :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_csv.reader,_csv.writer,_csv.register_dialect,csv.DictReader.__init__,csv.DictWriter.__init__: none of these take arbitrary keyword arguments like the stub currently says. Instead, they all take keyword arguments corresponding to the fieldnames on_csv.Dialect.