Skip to content

Remove redis - #13157

Merged
srittau merged 1 commit into
python:mainfrom
srittau:rm-redis
Nov 30, 2024
Merged

srittau merged 1 commit into
python:mainfrom
srittau:rm-redis

Conversation

@srittau

@srittau srittau commented Nov 29, 2024

Copy link
Copy Markdown
Collaborator

Closes: #10592

@github-actions

Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/blocks/redis.py:114: error: "Redis[bytes]" has no attribute "aclose"; maybe "close"?  [attr-defined]
+ src/prefect/blocks/redis.py:6: error: Library stubs not installed for "redis.asyncio"  [import-untyped]
+ src/prefect/blocks/redis.py:6: note: Hint: "python3 -m pip install types-redis"
+ src/prefect/blocks/redis.py:6: note: (or run "mypy --install-types" to install all missing stub packages)
+ src/prefect/blocks/redis.py:6: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
+ src/prefect/blocks/redis.py:6: error: Library stubs not installed for "redis"  [import-untyped]

django-stubs (https://github.com/typeddjango/django-stubs)
+ django-stubs/core/cache/backends/redis.pyi:8: error: Library stubs not installed for "redis.client"  [import-untyped]
+ django-stubs/core/cache/backends/redis.pyi:9: error: Library stubs not installed for "redis.connection"  [import-untyped]

@Avasam

Avasam commented Nov 29, 2024 •

Copy link
Copy Markdown
Collaborator

Also closes #12149 & #12988

All redis-related items can be completed from #9006

@srittau srittau linked an issue Nov 29, 2024 that may be closed by this pull request
@srittau

srittau commented Nov 29, 2024

Copy link
Copy Markdown
Collaborator Author

Thanks, I've crossed out the redis items in #9006, closed #12988, and added #12149 to the auto-close list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Various items missing from redis client's from_url kwargs Remove redis (not before February 2025)

3 participants