You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is another (IMHO blocking) reason to make this available on PyPI: as it stands, if the changes associated with bpo-30607 / cPython PR 2017 were merged, this would introduce a new dependency on Git in the cPython Docs build. Currently, there is no such dependency and, in fact, I know of at least one build process that depends on there being no dependency on Git. This would also affect any builders from cPython source tarballs, unless the release process were changed to bundle the docs theme into the source tarball. I would much prefer to see this as a PyPI download like the rest of the Docs build toolchain (e.g. Sphinx and friends).
I'd suggest a date based version - that way if we decide to update the look & feel, we can make the decision on whether or not to update old maintenance branches at the same time.
Activity
theacodes commentedon Dec 19, 2017
I suggested this for both this repo and its downstream pypa-docs-theme, but @ncoghlan raised some concerns.
JulienPalard commentedon Dec 21, 2017
There's https://pypi.python.org/pypi/python-docs-theme/ but with no files, do you remember the conerns?
ncoghlan commentedon Dec 24, 2017
IIRC, my main question was just asking what we'd gain from the extra update publication overhead relative to having users install from the git repo.
I'm OK with "We want to set a good example" as an answer to that question, though :)
ned-deily commentedon Jan 22, 2018
There is another (IMHO blocking) reason to make this available on PyPI: as it stands, if the changes associated with bpo-30607 / cPython PR 2017 were merged, this would introduce a new dependency on Git in the cPython Docs build. Currently, there is no such dependency and, in fact, I know of at least one build process that depends on there being no dependency on Git. This would also affect any builders from cPython source tarballs, unless the release process were changed to bundle the docs theme into the source tarball. I would much prefer to see this as a PyPI download like the rest of the Docs build toolchain (e.g. Sphinx and friends).
theacodes commentedon Jan 25, 2018
Great point, Ned. Since I own the PyPI record already, it's trivial to get this published.
@ncoghlan @Mariatta would you like to also be added as package owners in case I disappear / go rogue ?
Mariatta commentedon Jan 25, 2018
Thanks for asking :) Sure, feel free to add me.
ncoghlan commentedon Jan 25, 2018
Aye, happy to be a backup publisher :)
theacodes commentedon Jan 25, 2018
Great. It occurs to me that we need to think of a versioning strategy. Should we just match Python major.minor?
ncoghlan commentedon Jan 27, 2018
I'd suggest a date based version - that way if we decide to update the look & feel, we can make the decision on whether or not to update old maintenance branches at the same time.
theacodes commentedon Feb 2, 2018
SGTM. Created #11 and closing this as we've published. :)