Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions mypy/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -2424,8 +2424,9 @@ def is_kw_arg(self) -> bool:
return ARG_STAR2 in self.arg_kinds

def is_type_obj(self) -> bool:
return self.fallback.type.is_metaclass() and not isinstance(
get_proper_type(self.ret_type), UninhabitedType
return self.fallback.type.is_metaclass() and (
self.instance_type is not None
or not isinstance(get_proper_type(self.ret_type), UninhabitedType)
)

def get_instance_type(self, *, force_fallback: bool = False) -> ProperType:
Expand Down
18 changes: 18 additions & 0 deletions test-data/unit/check-classes.test
Original file line number Diff line number Diff line change
Expand Up @@ -8816,6 +8816,24 @@ if object():
if object():
reveal_type(D()) # N: Revealed type is "Never"

[case testNewNoReturnClassIsTypeObject]
from typing import NoReturn, TypeVar

T = TypeVar("T", bound=type[object])
def deco(cls: T) -> T: return cls

@deco
class A:
def __new__(cls) -> NoReturn: ...

a: type[A] = A
def f(o: object) -> None:
if isinstance(o, A):
reveal_type(o) # N: Revealed type is "__main__.A"
if object():
reveal_type(A()) # N: Revealed type is "Never"
[builtins fixtures/isinstance.pyi]

[case testOverloadedNewAndInitNoReturn]
from typing import NoReturn, overload

Expand Down
Loading