Repository navigation
Don't crash in try_infer_partial_type() if var.type is None. - #1752
Merged
Merged
Conversation
Collaborator
|
There probably is another underlying issue but it's not clear what is going on. This is a reasonable stopgap measure. We can revisit this if we encounter a small code example that resurfaces this problem elsewhere in the code. |
Member
Author
|
As I mentioned in #1747, it's probably due to other errors in the same function.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1747.
This is a rather dumb fix -- I just avoid the crash. But I don't feel like understanding it.