Skip to content

gh-93585: Set PyCode_Type.tp_basicsize to sizeof(PyCodeObject) #93587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vstinner wants to merge 1 commit into from
Closed

gh-93585: Set PyCode_Type.tp_basicsize to sizeof(PyCodeObject) #93587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Misc/NEWS.d/next/C API/2022-06-07-17-08-35.gh-issue-93585.EfIKlx.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Set ``PyCode_Type.tp_basicsize`` to ``sizeof(PyCodeObject)``. Cython makes the
assumption that ``PyCode_Type.tp_basicsize`` equals to
``sizeof(PyCodeObject)``. This assumption is no longer true since the commit
2bde6827ea4f136297b2d882480b981ff26262b6. Restore ``tp_basicsize`` until the
PyCodeObject structure can use a C99 flexible array of size zero with the
syntax ``char co_code_adaptive[]``. Patch by Victor Stinner.
2 changes: 1 addition & 1 deletion Objects/codeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1910,7 +1910,7 @@ static struct PyMethodDef code_methods[] = {
PyTypeObject PyCode_Type = {
PyVarObject_HEAD_INIT(&PyType_Type, 0)
"code",
offsetof(PyCodeObject, co_code_adaptive),
sizeof(PyCodeObject),
sizeof(_Py_CODEUNIT),
(destructor)code_dealloc, /* tp_dealloc */
0, /* tp_vectorcall_offset */
Expand Down