Repository navigation
gh-89519: Emit a warning when classmethod() wraps a non-callable descriptor - #92426
Closed
serhiy-storchaka wants to merge 1 commit into
Closed
serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
Contributor
|
I'm thinking that this should be a DeprecationWarning rather that a FutureWarning. |
Member
Author
|
It is a FutureWarning because in the future the behavior will be silently changed instead of be an error. This is for what FutureWarning was introduced. |
|
This PR is stale because it has been open for 30 days with no activity. |
Contributor
|
Rebase review found this PR obsolete: the classmethod descriptor chaining it warns about was removed in 3.13 by gh-110163 (7f9a99e); rebasing would resurrect deliberately deleted code and tests. Closing to cull the number of open pull requests. Do not reopen this pull request without getting a go-ahead from a triager or core developer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.