Repository navigation
gh-92261: Disallow iteration of Union (and other _SpecialForms) - #92262
Merged
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As #92261 describes,
list(Union)currently results in a hang because_SpecialForm.__getitem__is used for iteration, meaning thatlist(Union)effectively doesUnion[0], Union[1], ....This PR fixes it by implementing
_SpecialForm.__iter__, which takes priority over_SpecialForm.__getitem__when iterating.Edit: and now also explicitly setting
__iter__ = Noneon a number of other things intyping.py, to prevent similar errors with other things.