Repository navigation

bpo-46541: Replace core use of _Py_IDENTIFIER() with statically initialized global objects. - #30928

Merged

ericsnowcurrently merged 117 commits into

python:mainfrom

ericsnowcurrently:global-strings

Feb 8, 2022

Merged

bpo-46541: Replace core use of _Py_IDENTIFIER() with statically initialized global objects.#30928
ericsnowcurrently merged 117 commits into
python:mainfrom
ericsnowcurrently:global-strings

Commits on Feb 1, 2022
- Add _Py_STRING_LENGTH().
  ericsnowcurrently
  committed
  ec0c931
- Add PyInterpreterState._preallocated.strings (identifiers-only for now).
  ericsnowcurrently
  committed
  cea1335
- Move the strings to _PyRuntimeState.
  ericsnowcurrently
  committed
  a5513fc
- Initialize the global singleton strings (identifiers-only for now).
  ericsnowcurrently
  committed
  dd084ee
- Add the global (non-identifier) string literals.
  ericsnowcurrently
  committed
  472b0a6
- Add _PyObject_CallMethod().
  ericsnowcurrently
  committed
  8a3096b
- Get rid of _Py_IDENTIFIER() in tokenizer.c.
  ericsnowcurrently
  committed
  38300b3
- Add _PyDict_GetItemWithError().
  ericsnowcurrently
  committed
  fb9fe24
- Set the hash if not set yet.
  ericsnowcurrently
  committed
  7fa8e83
- Add _PySys_GetAttr().
  ericsnowcurrently
  committed
  9563c27
- Get rid of _Py_IDENTIFIER() in _warnings.c.
  ericsnowcurrently
  committed
  674e40b
- _PyObject_LookupSpecial() -> _PyObject_LookupSpecialId().
  ericsnowcurrently
  committed
  e5e7483
- Add _PyObject_LookupSpecial().
  ericsnowcurrently
  committed
  07ac6ba
- Get rid of _Py_IDENTIFIER() in bltinmodule.c.
  ericsnowcurrently
  committed
  249e830
- Get rid of _Py_IDENTIFIER() in ceval.c.
  ericsnowcurrently
  committed
  3ea3c09
- Add a TODO.
  ericsnowcurrently
  committed
  5713dab
- Get rid of _Py_IDENTIFIER() in specialize.c.
  ericsnowcurrently
  committed
  77a21d6
- Get rid of _Py_IDENTIFIER() in traceback.c.
  ericsnowcurrently
  committed
  704d440
- Get rid of _Py_IDENTIFIER() in codecs.c.
  ericsnowcurrently
  committed
  2800db6
- Get rid of _Py_IDENTIFIER() in compile.c.
  ericsnowcurrently
  committed
  db72429
- Get rid of _Py_IDENTIFIER() in importdl.c.
  ericsnowcurrently
  committed
  737391f
- Get rid of _Py_IDENTIFIER() in marshal.c.
  ericsnowcurrently
  committed
  9e3ff70
- Get rid of _Py_IDENTIFIER() in errors.c.
  ericsnowcurrently
  committed
  71fc362
- Get rid of _Py_IDENTIFIER() in import.c.
  ericsnowcurrently
  committed
  2046b53
- Add _PySys_SetAttr().
  ericsnowcurrently
  committed
  a4c1aa9
- Get rid of _Py_IDENTIFIER() in pylifecycle.c.
  ericsnowcurrently
  committed
  48fcb06
- Get rid of _Py_IDENTIFIER() in pythonrun.c.
  ericsnowcurrently
  committed
  c9bc124
- Get rid of _Py_IDENTIFIER() in sysmodule.c.
  ericsnowcurrently
  committed
  816c630
- Get rid of _Py_IDENTIFIER() in typeobject.c.
  ericsnowcurrently
  committed
  ef2b061
- Get rid of _Py_IDENTIFIER() in abstract.c.
  ericsnowcurrently
  committed
  4e03f95
- Add _PyEval_GetBuiltin().
  ericsnowcurrently
  committed
  814ec4a
- Get rid of _Py_IDENTIFIER() in descrobject.c.
  ericsnowcurrently
  committed
  a91fe82
- Get rid of _Py_IDENTIFIER() in moduleobject.c.
  ericsnowcurrently
  committed
  25a2ec4
- Get rid of _Py_IDENTIFIER() in object.c.
  ericsnowcurrently
  committed
  865cc8a
- Get rid of _Py_IDENTIFIER() in bytearrayobject.c.
  ericsnowcurrently
  committed
  e4c2f0d
- Get rid of _Py_IDENTIFIER() in bytesobject.c.
  ericsnowcurrently
  committed
  f82baa8
- Get rid of _Py_IDENTIFIER() in classobject.c.
  ericsnowcurrently
  committed
  4b10323
- Get rid of _Py_IDENTIFIER() in complexobject.c.
  ericsnowcurrently
  committed
  ffd9493
- Get rid of _Py_IDENTIFIER() in dictobject.c.
  ericsnowcurrently
  committed
  ddd887b
- Get rid of _Py_IDENTIFIER() in enumobject.c.
  ericsnowcurrently
  committed
  0a02936
- Get rid of _Py_IDENTIFIER() in exceptions.c.
  ericsnowcurrently
  committed
  d157842
- Get rid of _Py_IDENTIFIER() in fileobject.c.
  ericsnowcurrently
  committed
  297240c
- Get rid of _Py_IDENTIFIER() in frameobject.c.
  ericsnowcurrently
  committed
  875353d
- Get rid of _Py_IDENTIFIER() in funcobject.c.
  ericsnowcurrently
  committed
  9138b2e
- Get rid of _Py_IDENTIFIER() in genericaliasobject.c.
  ericsnowcurrently
  committed
  5e576f0
- Get rid of _Py_IDENTIFIER() in genobject.c.
  ericsnowcurrently
  committed
  7591bf1
- Get rid of _Py_IDENTIFIER() in iterobject.c.
  ericsnowcurrently
  committed
  f27547e
- Get rid of _Py_IDENTIFIER() in listobject.c.
  ericsnowcurrently
  committed
  dd3900f
- Get rid of _Py_IDENTIFIER() in longobject.c.
  ericsnowcurrently
  committed
  ecd568d
- Get rid of _Py_IDENTIFIER() in methodobject.c.
  ericsnowcurrently
  committed
  187133d
- Get rid of _Py_IDENTIFIER() in odictobject.c.
  ericsnowcurrently
  committed
  e04947e
- Get rid of _Py_IDENTIFIER() in rangeobject.c.
  ericsnowcurrently
  committed
  91ef303
- Get rid of _Py_IDENTIFIER() in setobject.c.
  ericsnowcurrently
  committed
  21c564a
- Get rid of _Py_IDENTIFIER() in structseq.c.
  ericsnowcurrently
  committed
  d833719
- Get rid of _Py_IDENTIFIER() in tupleobject.c.
  ericsnowcurrently
  committed
  329f8fd
- Get rid of _Py_IDENTIFIER() in unicodeobject.c.
  ericsnowcurrently
  committed
  0cbeb2d
- Get rid of _Py_IDENTIFIER() in unionobject.c.
  ericsnowcurrently
  committed
  972044a
- Get rid of _Py_IDENTIFIER() in weakrefobject.c.
  ericsnowcurrently
  committed
  e55556f
- Get rid of _Py_IDENTIFIER() in _pickle.c.
  ericsnowcurrently
  committed
  5e32d13
- Add _PyObject_CallMethodObj().
  ericsnowcurrently
  committed
  6081cf1
- Use _PyObject_CallMethodObj().
  ericsnowcurrently
  committed
  6aa5674
- _PyObject_CallMethod() -> _PyObject_CallMethodFormat().
  ericsnowcurrently
  committed
  37c0200
- _PyObject_CallMethodObj() -> _PyObject_CallMethod().
  ericsnowcurrently
  committed
  10f82cd
- Get rid of _Py_IDENTIFIER() in the _io module.
  ericsnowcurrently
  committed
  85f16a4
- Get rid of _Py_IDENTIFIER() in _threadmodule.c.
  ericsnowcurrently
  committed
  aa641a3
- Get rid of _Py_IDENTIFIER() in _abc.c.
  ericsnowcurrently
  committed
  dda08ad
- Get rid of _Py_IDENTIFIER() in faulthandler.c.
  ericsnowcurrently
  committed
  4d75c6b
- Get rid of _Py_IDENTIFIER() in _collectionsmodule.c.
  ericsnowcurrently
  committed
  9d36c02
- Get rid of _Py_IDENTIFIER() in itertoolsmodule.c.
  ericsnowcurrently
  committed
  1f42649
- Get rid of _Py_IDENTIFIER() in posixmodule.c.
  ericsnowcurrently
  committed
  c2f1cfb
- Get rid of _Py_IDENTIFIER() in _operator.c.
  ericsnowcurrently
  committed
  3ed68a7
- Get rid of _Py_IDENTIFIER() in timemodule.c.
  ericsnowcurrently
  committed
  d86ceb1
- Get rid of _Py_IDENTIFIER() in main.c.
  ericsnowcurrently
  committed
  c0c6777
- Get rid of _Py_static_string() in typeobject.c.
  ericsnowcurrently
  committed
  c9f4563
- Get rid of _Py_static_string() in ast_opt.c.
  ericsnowcurrently
  committed
  0796475
- Get rid of _Py_static_string() in compile.c.
  ericsnowcurrently
  committed
  3e5fac3
- Disallow _Py_IDENTIFIER in core.
  ericsnowcurrently
  committed
  77d423e
- Leave all the functions.
  ericsnowcurrently
  committed
  308fb9e
- Auto-generate the global strings.
  ericsnowcurrently
  committed
  2136577
- Drop _Py_unicode_state.empty_string.
  ericsnowcurrently
  committed
  b14d0a8
- Do not include the latin-1 characters (for now).
  ericsnowcurrently
  committed
  61abdab
- Use a better prefix for the field names.
  ericsnowcurrently
  committed
  db9de0a
- Clean up the declarations a little.
  ericsnowcurrently
  committed
  1074b77
- Add _Py_IS_POINTER_FROM_VAR().
  ericsnowcurrently
  committed
  d4f58fd
- Consider all global strings as singletons.
  ericsnowcurrently
  committed
  09c2a51
- _Py_IS_POINTER_FROM_VAR() -> _PyObject_IsSingleton().
  ericsnowcurrently
  committed
  983dda0
- Add _PyUnicode_InternSafe().
  ericsnowcurrently
  committed
  3fbc75f
- Intern the global strings when used.
  ericsnowcurrently
  committed
  bd8b74c
- Limit when we check the global strings for consistency.
  ericsnowcurrently
  committed
  b305ded
- Drop _PyUnicode_InternSafe().
  ericsnowcurrently
  committed
  3da2d65
- Add a --check option to generate_global_objects.py.
  ericsnowcurrently
  committed
  3673bbd
- Drop unused global strings.
  ericsnowcurrently
  committed
  9a419a7
- Check the global objects in CI.
  ericsnowcurrently
  committed
  c6a292d
- Fix _PyObject_CallMethod() for size_t.
  ericsnowcurrently
  committed
  ffbd515
- Dump the exception if normal printing fails.
  ericsnowcurrently
  committed
  878059b
- Regenerate test_frozenmain.h.
  ericsnowcurrently
  committed
  780e61f
- Add some identifiers that are only used in non-debug builds.
  ericsnowcurrently
  committed
  876aa77
- Drop _PyObject_CallMethod_SizeT().
  ericsnowcurrently
  committed
  f0bd78d
- Merge branch 'main' into global-strings
  ericsnowcurrently
  committed
  d575057
- Cast to void* before casting to uint64_t.
  ericsnowcurrently
  committed
  db92384
- Explicitly mark each module that still uses _Py_IDENTIFIER().
  ericsnowcurrently
  committed
  955d26a
- _testembed still uses _Py_IDENTIFIER().
  ericsnowcurrently
  committed
  3c66484
- Fix name collisions from Windows.
  ericsnowcurrently
  committed
  05fd034
Commits on Feb 4, 2022
- _Py_GET_GLOBAL_IDENTIFIER() -> _Py_ID().
  ericsnowcurrently
  committed
  78482cf
- _Py_GET_GLOBAL_STRING() -> _Py_STR().
  ericsnowcurrently
  committed
  72316f4
- Use a simpler field prefix than spamspamspam_.
  ericsnowcurrently
  committed
  75b6a83
- ASCII_STR() -> STRUCT_FOR_ASCII_STR().
  ericsnowcurrently
  committed
  7b670c1
- LITERAL() -> STRUCT_FOR_STR().
  ericsnowcurrently
  committed
  144ed0f
- ID() -> STRUCT_FOR_ID().
  ericsnowcurrently
  committed
  f3aa225
- Use _PyObject_IMMORTAL_INIT().
  ericsnowcurrently
  committed
  050b34b
- Drop _Py_STRING_LENGTH().
  ericsnowcurrently
  committed
  dbec341
- Inline uses of _Py_ID().
  ericsnowcurrently
  committed
  7a075ac
- Inline uses of _Py_STR().
  ericsnowcurrently
  committed
  6fdba80
- Drop _PyObject_IsSingleton(). (C99 undefined makes it too tricky.)
  ericsnowcurrently
  committed
  4e00c87
- Drop address-taking from _PY_ID() and _Py_STR().
  ericsnowcurrently
  committed
  fbe8f4a
- Add a compatibility shim for _PyObject_LookupSpecialId().
  ericsnowcurrently
  committed
  f2d9b81
- Merge branch 'main' into global-strings
  ericsnowcurrently
  committed
  7781025

Commits

Commits on Feb 1, 2022

Commits on Feb 4, 2022