Skip to content

gh-85792: Remove the shebang of internal Tools to avoid confusion. #23581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shihai1991 wants to merge 3 commits into from
Closed

gh-85792: Remove the shebang of internal Tools to avoid confusion. #23581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28bb352
Remove the shebang of inner Tools.
shihai1991 Nov 30, 2020
b150909
apply petr's comment
shihai1991 Dec 4, 2020
c3518a3
Resolve confilict
shihai1991 Nov 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Mac/BuildScript/build-installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#!/usr/bin/env python
"""
This script is used to build "official" universal installers on macOS.

Expand Down
3 changes: 1 addition & 2 deletions Objects/typeslots.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#!/usr/bin/python
# Usage: typeslots.py < Include/typeslots.h typeslots.inc
# Usage: ./python Objects/typeslots.py < Include/typeslots.h typeslots.inc

import sys, re

Expand Down
1 change: 0 additions & 1 deletion Parser/asdl_c.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#! /usr/bin/env python
"""Generate C code from an ASDL description."""

import sys
Expand Down
1 change: 0 additions & 1 deletion Python/makeopcodetargets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#! /usr/bin/env python

@encukou encukou Dec 4, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think makeopcodetargets needs a locally built Python. Does it?

@shihai1991 shihai1991 Dec 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. It will be called in makefile: https://github.com/python/cpython/blob/master/Makefile.pre.in#L946.
So I think the shebang haven't worked in here.

"""Generate C code for the jump table of the threaded code interpreter
(for compilers supporting computed gotos or "labels-as-values", such as gcc).
"""
Expand Down
2 changes: 0 additions & 2 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#!/usr/bin/env python3
#

@encukou encukou Dec 4, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Clinic needs a locally built Python.

@shihai1991 shihai1991 Dec 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It doesn't need a local builtin python. There have docs to introduce how to run this clinic.py. So I think remove it would be better(Avoid update the python version again and again).

# Argument Clinic
# Copyright 2012-2013 by Larry Hastings.
# Licensed to the PSF under a contributor agreement.
Expand Down
2 changes: 0 additions & 2 deletions Tools/peg_generator/pegen/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#!/usr/bin/env python3.8

"""pegen -- PEG Generator.

Search the web for PEG Parsers for reference.
Expand Down