Skip to content

bpo-41354: Adjust filecmp.cmp() to match documentation #21580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chanke-mpcdf wants to merge 1 commit into from
Closed

bpo-41354: Adjust filecmp.cmp() to match documentation #21580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Lib/filecmp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ def cmp(f1, f2, shallow=True):
s2 = _sig(os.stat(f2))
if s1[0] != stat.S_IFREG or s2[0] != stat.S_IFREG:
return False
if shallow and s1 == s2:
return True
if s1[1] != s2[1]:
if s1 != s2:

@akulakov akulakov Jul 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like if mtime is different but otherwise files are the same, current code will return True but this PR will change it to return False. That both breaks backwards compatibility and doesn't seem right to me.

return False
if shallow:
return True

outcome = _cache.get((f1, f2, s1, s2))
if outcome is None:
Expand Down