Repository navigation
[3.14] gh-159739: Hold the codec registry lock while unregistering (GH-160168) - #160485
Merged
JelleZijlstra merged 1 commit intoOct 24, 2026
Merged
Conversation
…ing (pythonGH-160168) Concurrent calls to codecs.unregister() can shrink the search path between its length check and indexed lookup in a free-threaded build. The lookup then returns NULL and an unconditional decref crashes the interpreter; hold the registry mutex across the scan and removal. Also reported in pythongh-157078. Backport to 3.15 and 3.14. (cherry picked from commit 784b305) Co-authored-by: Jelle Zijlstra <jelle@openai.com>
This was referenced Oct 23, 2026
JelleZijlstra
marked this pull request as ready for review
October 23, 2026 20:35
JelleZijlstra
enabled auto-merge (squash)
October 24, 2026 20:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent calls to codecs.unregister() can shrink the search path between its length check and indexed lookup in a free-threaded build. The lookup then returns NULL and an unconditional decref crashes the interpreter; hold the registry mutex across the scan and removal. Also reported in gh-157078. Backport to 3.15 and 3.14.
(cherry picked from commit 784b305)
Co-authored-by: Jelle Zijlstra jelle@openai.com
Backport of #160168 to 3.14.
Hold 3.14's codec search-path mutex across the length check, lookup, and removal. Release it before dropping the temporary reference.
Ran
test_codecson a free-threaded 3.14 build. Eight threads completed 102,400 register/unregister pairs with the GIL disabled.