Repository navigation
[3.14] gh-160179: Leave bytearray empty when __init__() fails midway (GH-160180) - #160204
Merged
Merged
Conversation
…idway (pythonGH-160180) The list/tuple fast path and the buffer path resized the object before filling it and did not undo the resize on error, leaving stale bytes. (cherry picked from commit 5a63d35)
gpshead
marked this pull request as ready for review
October 22, 2026 05:27
gpshead
enabled auto-merge (squash)
October 22, 2026 05:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list/tuple fast path and the buffer path resized the object before
filling it and did not undo the resize on error, leaving stale bytes.
(cherry picked from commit 5a63d35)
Manual backport notes (3.14): the
Objects/bytearrayobject.cchange appliedunchanged.
Lib/test/test_bytes.pyconflicted only on placement. On main thenew test follows the gh-153419
test_reinit_*tests, which 3.14 doesn't have,so
test_reinit_errorgoes at the end ofByteArrayTestinstead. The testitself is unchanged.