Repository navigation
gh-148228: Render REPL error overlays in brackets and non-bold red - #160008
Open
johnslavik wants to merge 2 commits into
Open
johnslavik wants to merge 2 commits into
johnslavik wants to merge 2 commits into
Conversation
johnslavik
requested review from
ambv,
lysnikolaou and
pablogsal
as code owners
October 21, 2026 02:02
Member
Author
|
Hmmm or maybe we should do |
johnslavik
changed the title
Member
Author
|
We're golden |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render REPL error overlays as
[ error message ], analogous to completion messages such as[ not unique ]. The brackets distinguish errors from stdout even when color is disabled. When color is enabled, the whole message uses non-bold red.For example,
! nothing to yankbecomes[ nothing to yank ].