Skip to content

gh-54767: Respect --disable-loadable-sqlite-extensions in configure - #159728

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
vasiliyk:gh-54767-sqlite-ext
Oct 21, 2026
Merged

serhiy-storchaka merged 1 commit into
python:mainfrom
vasiliyk:gh-54767-sqlite-ext

Conversation

@vasiliyk

@vasiliyk vasiliyk commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

configure ignored the value of --enable-loadable-sqlite-extensions, so =no and --disable-loadable-sqlite-extensions still defined PY_SQLITE_ENABLE_LOAD_EXTENSION.

This PR tests the value instead. Plain --enable-loadable-sqlite-extensions is unchanged.

…gure

The option was enabled for every spelling, including =no and --disable-.

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Now --enable-loadable-sqlite-extensions --enable-loadable-sqlite-extensions=no and --enable-loadable-sqlite-extensions --disable-loadable-sqlite-extensions work as expected -- disable extensions.

@serhiy-storchaka
serhiy-storchaka merged commit 0d35e3b into python:main Oct 21, 2026
57 checks passed
@vasiliyk
vasiliyk deleted the gh-54767-sqlite-ext branch October 21, 2026 13:35
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD14 3.x (tier-3) has failed when building commit 0d35e3b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1232/builds/9761) and take a look at the build logs.
  4. Check if the failure is related to this commit (0d35e3b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1232/builds/9761

Failed tests:

  • test.test_os.test_os

Failed subtests:

  • test_timerfd_non_blocking - test.test_os.test_os.TimerfdTests.test_timerfd_non_blocking

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/support/__init__.py", line 989, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('127.0.0.1', 22938), raddr=('127.0.0.1', 55220)>
Warning -- Unraisable exception
Exception ignored while calling deallocator <function _SelectorTransport.__del__ at 0x65da591a90>:
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/asyncio/selector_events.py", line 882, in __del__
    _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ResourceWarning: unclosed transport <_SelectorSocketTransport closing fd=8>
k


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/support/__init__.py", line 989, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('127.0.0.1', 34295), raddr=('127.0.0.1', 49724)>
Warning -- Unraisable exception
Exception ignored while calling deallocator <function _SelectorTransport.__del__ at 0x323b02264e90>:
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/asyncio/selector_events.py", line 882, in __del__
    _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ResourceWarning: unclosed transport <_SelectorSocketTransport closing fd=9>
k


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/test_os/test_os.py", line 4231, in test_timerfd_non_blocking
    self.assertEqual(self.read_count_signaled(fd), 1)
                     ~~~~~~~~~~~~~~~~~~~~~~~~^^^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/test_os/test_os.py", line 4190, in read_count_signaled
    data = os.read(fd, 8)
BlockingIOError: [Errno 35] Resource temporarily unavailable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants