Skip to content

gh-87613: Use AC vectorcall for slice() #159471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eendebakpt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-87613: Use AC vectorcall for slice() #159471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-10-15-12-40-00.gh-issue-87613.Sl1ceV.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Speed up calling :class:`slice` by adding a vectorcall implementation of the constructor generated by Argument Clinic. Patch by Pieter Eendebak.
78 changes: 78 additions & 0 deletions Objects/clinic/sliceobject.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 22 additions & 11 deletions Objects/sliceobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ this type and there is exactly one in existence.
#include "pycore_object.h" // _PyObject_GC_TRACK()
#include "pycore_sliceobject.h" // _PyBuildSlice_ConsumeRefs

#include "clinic/sliceobject.c.h"

/*[clinic input]
class slice "PySliceObject *" "&PySlice_Type"
[clinic start generated code]*/
/*[clinic end generated code: output=da39a3ee5e6b4b0d input=857b514967456ef4]*/


#define _PySlice_CAST(op) _Py_CAST(PySliceObject*, (op))

Expand Down Expand Up @@ -308,19 +315,22 @@ PySlice_GetIndicesEx(PyObject *_r, Py_ssize_t length,
return 0;
}

static PyObject *
slice_new(PyTypeObject *type, PyObject *args, PyObject *kw)
{
PyObject *start, *stop, *step;
/*[clinic input]
@classmethod
@vectorcall
slice.__new__ as slice_new

start = stop = step = NULL;

if (!_PyArg_NoKeywords("slice", kw))
return NULL;

if (!PyArg_UnpackTuple(args, "slice", 1, 3, &start, &stop, &step))
return NULL;
start: object
stop: object(c_default="NULL") = None
step: object(c_default="NULL") = None
/
[clinic start generated code]*/

static PyObject *
slice_new_impl(PyTypeObject *type, PyObject *start, PyObject *stop,
PyObject *step)
/*[clinic end generated code: output=35a6e86397efb677 input=cf5c572a0d2caa22]*/
{
/* This swapping of stop and start is to maintain similarity with
range(). */
if (stop == NULL) {
Expand Down Expand Up @@ -702,4 +712,5 @@ PyTypeObject PySlice_Type = {
0, /* tp_init */
0, /* tp_alloc */
slice_new, /* tp_new */
.tp_vectorcall = slice_vectorcall,
};
Loading