Skip to content

gh-126273: Fix make clinic warnings - #158892

Merged
StanFromIreland merged 1 commit into
python:mainfrom
cmaloney:make_clinic_permit_long_summary_warnings
Oct 6, 2026
Merged

StanFromIreland merged 1 commit into
python:mainfrom
cmaloney:make_clinic_permit_long_summary_warnings

Conversation

@cmaloney

@cmaloney cmaloney commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

These no longer have long summaries.

make clinic was outputting:

Warning in file '../cpython/Modules/_elementtree.c' on line 3779:
Remove the @permit_long_summary decorator from '_elementtree.XMLParser.init'!

Warning in file '../cpython/Modules/pyexpat.c' on line 1083:
Remove the @permit_long_summary decorator from 'pyexpat.xmlparser.GetInputContext'!

These no longer have long summaries.

`make clinic` was outputting:
> Warning in file '../cpython/Modules/_elementtree.c' on line 3779:
> Remove the @permit_long_summary decorator from '_elementtree.XMLParser.__init__'!
>
>
> Warning in file '../cpython/Modules/pyexpat.c' on line 1083:
> Remove the @permit_long_summary decorator from 'pyexpat.xmlparser.GetInputContext'!
@cmaloney cmaloney changed the title gh-126273, gh-56821: Fix make clinic warnings gh-126273: Fix make clinic warnings Oct 6, 2026

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will write a patch to catch this in the CI, to avoid such things in the future.

@StanFromIreland
StanFromIreland merged commit 2db299d into python:main Oct 6, 2026
61 checks passed
@cmaloney
cmaloney deleted the make_clinic_permit_long_summary_warnings branch October 6, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants