Repository navigation
[3.10] gh-156293: Use-after-free for server-side SSLContext with sni_callback (GH-158504) - #158524
Merged
Merged
Conversation
gpshead
commented
Sep 30, 2026
gpshead
commented
Member
- Issue: Use-after-free for server-side SSLContext with sni_callback #156293
…ugh a released SSLContext The servername (SNI) callback located its SSLContext through a borrowed pointer registered with OpenSSL, which can outlive the SSLContext object. Look the context up from the SSL object instead, and unregister the callback when the context is deallocated. Backport of 87665c9, adapted to this branch's servername callback code.
bedevere-app
Bot
added
awaiting core review
topic-SSL
type-security
Documentation build overview
550 files changed ·
|
icanhasmath
pushed a commit
to ActiveState/cpython
that referenced
this pull request
Oct 28, 2026
…h sni_callback (pythonGH-158504) (python#158524) * [3.10] pythongh-156293: ssl: do not call the servername callback through a released SSLContext The servername (SNI) callback located its SSLContext through a borrowed pointer registered with OpenSSL, which can outlive the SSLContext object. Look the context up from the SSL object instead, and unregister the callback when the context is deallocated. Backport of 87665c9, adapted to this branch's servername callback code. * [3.10] pythongh-156293: Document sni_callback dispatch after a context switch (cherry picked from commit ec44b5a) 3.9.25.x: hand-merged into 3.9's _servername_callback(), which still names the context ssl_ctx; Py_NewRef()/Py_XNewRef() (3.10+) are spelled as Py_INCREF() and the 3.9 PySSLSocket_Check() assert is kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.