Repository navigation
[3.15] gh-154335: Allow disabling terminal colors in Tachyon's pstats_collector module (GH-154344) - #158122
Merged
Conversation
…_collector` module (pythonGH-154344) * Use _colorize.get_colors() to allow disabling ANSI escape codes through environment variables * add news entry * use get_colors() instead of ANSIColors enum also in Lib/profiling/sampling/sample.py * fix data_lines collection of pstats lines for no-color mode * preserve lazy import of _colorize * pythongh-154335: Cover profiler color policy and update NEWS --------- (cherry picked from commit 0546b5f) Co-authored-by: Peter Fackeldey <fackeldey.peter@gmail.com> Co-authored-by: Pablo Galindo Salgado <pablogsal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use _colorize.get_colors() to allow disabling ANSI escape codes through environment variables
add news entry
use get_colors() instead of ANSIColors enum also in Lib/profiling/sampling/sample.py
fix data_lines collection of pstats lines for no-color mode
preserve lazy import of _colorize
Tachyon's
pstats_collectordoes not respect "no-color" modes #154335: Cover profiler color policy and update NEWS(cherry picked from commit 0546b5f)
Co-authored-by: Peter Fackeldey fackeldey.peter@gmail.com
Co-authored-by: Pablo Galindo Salgado pablogsal@gmail.com