Skip to content

gh-150045: Add frozendict support to the compiler and AST constants - #150050

Closed
lgeiger wants to merge 5 commits into
python:mainfrom
lgeiger:ast-frozendict
Closed

lgeiger wants to merge 5 commits into
python:mainfrom
lgeiger:ast-frozendict

Conversation

@lgeiger

@lgeiger lgeiger commented May 19, 2026 •

Copy link
Copy Markdown
Contributor

This adapts the compiler to treat frozendict as a valid constant similar to frozenset:

  • 37d8189 adds frozendict to ast constants
  • b027839 adds support for deduplication via _PyCode_ConstantKey
  • 992b4b6 adds recursive constant merging which make
  • aeed04a fixes the freethreading case

Let me know if you'd like me to split this up into separate PRs, this has become a much larger than I had originally intended.

@lgeiger
lgeiger requested a review from methane as a code owner May 19, 2026 02:38
@picnixz

picnixz commented May 19, 2026

Copy link
Copy Markdown
Member

The consensus on the issue is not reached and there is still opposition, hence marking as pending.

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 19, 2026
@lgeiger lgeiger closed this Aug 19, 2026
@lgeiger
lgeiger deleted the ast-frozendict branch August 19, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review DO-NOT-MERGE stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants