Repository navigation
gh-148228: Enable error overlays in the REPL - #148229
Conversation
johnslavik
changed the title
| t = THEME() | ||
| error_prefix = f"{t.error}{error_prefix}{t.reset}" | ||
| self.console.beep() | ||
| self.msg = error_prefix + msg |
There was a problem hiding this comment.
Maybe I am misreading this flow but if I am not wrong, the error() now embeds the escape sequences into self.msg. The message renderer at _render_message_lines slices by string length, not visible width. Then, len(message_line) counts the ANSI bytes (\x1b[1;31m ... \x1b[0m), so on narrow terminals (or long error messages) the slice boundary can land mid-escape, producing a truncated \x1b[ on one line and stray m on the next leaving the whole line un-colored or visually corrupted.
There was a problem hiding this comment.
I wired it to use the same wrapping method as layout_content_lines. Should be fine now!
(Taking this to extremes, we don't handle splitting prompt string if terminal is too narrow. Technically anyone can set their own prompt string, so maybe we should?)
Documentation build overview
19 files changed ·
|
1d02b0f to
8cb9bc0
Compare
When you press Tab and nothing matches, the REPL now shows
! no matches, so you know why it did nothing:Screen.Recording.2026-04-07.at.19.04.58.mov
If a history search finds nothing, or Ctrl-Y has no cut text to insert, the REPL explains why. It also reports keys with no command assigned, so you can tell whether it understood your shortcut:
Screen.Recording.2026-04-07.at.19.08.58.mov
The REPL always created these messages, but they were discarded silently. This PR displays them temporarily below the input and asks the terminal to beep. The
!prefix is colored when color is enabled.I've made some opinionated choices on which messages should go through or not, e.g. moving past the start or end of the input stays silent because messages there would make ordinary editing distracting. As the issue notes, some messages still may need clearer wording, and accidental shortcuts can produce a message and beep. Any opinions on these would be very welcome (especially around how we present unknown shortcuts).
Tests cover messages, beep calls, colors, and line wrapping on narrow terminals, including text with color codes, wide characters, and combining accents.