Repository navigation
gh-145824: email.utils: replace AttributeError with TypeError in collapse_rfc2231_value for non-string non-3-tuple input
#145825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stefanzetzsche
wants to merge
8
commits into
python:main
Choose a base branch
from
stefanzetzsche:fix/email_utils_collapse_non3_tuple
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+14
−1
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
93e7c1a
gh-XXXXX: Fix email.utils.collapse_rfc2231_value crash on non-3-tuples
stefanzetzsche 3dec095
Merge branch 'main' of https://github.com/python/cpython into fix/ema…
stefanzetzsche d85561d
Add test for collapse_rfc2231_value with non-3-tuples
stefanzetzsche 972b489
📜🤖 Added by blurb_it.
blurb-it[bot] 741d554
email.utils: raise TypeError for non-string non-3-tuple, update docs
stefanzetzsche ab72bac
Merge branch 'fix/email_utils_collapse_non3_tuple' of https://github.…
stefanzetzsche 0a7bd9d
Update NEWS entry to reflect TypeError change
stefanzetzsche 72f7c75
Address review: remove LLM comments, use top-level import, drop redun…
stefanzetzsche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Library/2026-03-11-14-42-23.gh-issue-145824.HMjVqq.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| :func:`email.utils.collapse_rfc2231_value` now raises :exc:`TypeError` | ||
| instead of :exc:`AttributeError` when called with a value that is neither a | ||
| string nor a 3-tuple. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and add
from test import supportat the top of the file if necessary. IfsubTestsis already imported, use it as is.