Skip to content

gh-126040: add versioning to XML elements to protect against evil mutations - #126041

Closed
picnixz wants to merge 5 commits into
python:mainfrom
picnixz:fix/element-tree-versioning-126040
Closed

picnixz wants to merge 5 commits into
python:mainfrom
picnixz:fix/element-tree-versioning-126040

Conversation

@picnixz

@picnixz picnixz commented Oct 27, 2024 •

Copy link
Copy Markdown
Member

For now, I just want to add the attributes and update them accordingly. I'll fix each bad case in a separate PR.

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, I was thinking about something like that :)

@picnixz

This comment was marked as resolved.

@picnixz

picnixz commented Dec 8, 2024

Copy link
Copy Markdown
Member Author

Closing since we won't need this feature for protecting remove() (and find(), even though I haven't checked. Will re-open if needed).

@picnixz picnixz closed this Dec 8, 2024
@picnixz
picnixz deleted the fix/element-tree-versioning-126040 branch December 8, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants