Repository navigation
gh-115249: Fix test_descr with -OO mode - #115250
Merged
Merged
Conversation
Member
|
The Windows 86 free-threading failure in test_queue (timeout) is an independent failure reported in ##115258. Since the same passed on another of your PRs, I triggered a one-test rerun. |
terryjreedy
approved these changes
Feb 10, 2024
terryjreedy
left a comment
terryjreedy
left a comment
Member
There was a problem hiding this comment.
Looks like the proper fix for a buggy test.
Closed
serhiy-storchaka
approved these changes
Feb 10, 2024
sobolevn
added
needs backport to 3.11
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 11, 2024
(cherry picked from commit 1f23837) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-115277 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 11, 2024
(cherry picked from commit 1f23837) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-115278 is a backport of this pull request to the 3.11 branch. |
Member
|
Congrats @sobolevn for your first merge as a Python core dev! 🎉 |
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now it passes with both
-00and without.test_descrfails when run with-OO#115249