Skip to content

gh-106812: Fix two tiny bugs in analysis.py - #107649

Merged
gvanrossum merged 1 commit into
python:mainfrom
gvanrossum:fix-analysis
Aug 5, 2023
Merged

gvanrossum merged 1 commit into
python:mainfrom
gvanrossum:fix-analysis

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Aug 5, 2023 •

Copy link
Copy Markdown
Member

This fixes two tiny defects in analysis.py that I didn't catch on time in #107564:

  • get_var_names in check_macro_consistency should skip UNUSED names.
  • Fix an occurrence of is UNUSED (should be ==).

I plan to just land this once the tests pass. OTOH I might tack on additional issues if I happen to run into them over the weekend.

@gvanrossum gvanrossum changed the title Fix two tiny bugs in analysis.py gh-106812: Fix two tiny bugs in analysis.py Aug 5, 2023
@gvanrossum
gvanrossum enabled auto-merge (squash) August 5, 2023 04:05
@gvanrossum
gvanrossum merged commit 85e5b1f into python:main Aug 5, 2023
@gvanrossum
gvanrossum deleted the fix-analysis branch August 5, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants