Skip to content

Make the correct call specialization fail kind show up #99770

Closed
Closed
Make the correct call specialization fail kind show up#99770
Labels
type-bugAn unexpected behavior, bug, or error

Description

@penguin-wwy
penguin-wwy
opened on Nov 25, 2022

The SPEC_FAIL_KIND is not displayed correctly due to not being adequately maintained.
e.g

cpython/Python/specialize.c

Lines 1471 to 1482 in b1dcdef

#ifdef Py_STATS
static int
builtin_call_fail_kind(int ml_flags)
{
switch (ml_flags & (METH_VARARGS | METH_FASTCALL | METH_NOARGS | METH_O |
METH_KEYWORDS | METH_METHOD)) {
case METH_VARARGS:
return SPEC_FAIL_CALL_PYCFUNCTION;
case METH_VARARGS | METH_KEYWORDS:
return SPEC_FAIL_CALL_PYCFUNCTION_WITH_KEYWORDS;
case METH_FASTCALL | METH_KEYWORDS:
return SPEC_FAIL_CALL_PYCFUNCTION_FAST_WITH_KEYWORDS;

According to the context, METH_FASTCALL | METH_KEYWORDS flag does not cause specialization failure.
However, the method descr fail kind will also be shown as SPEC_FAIL_CALL_PYCFUNCTION, because builtin_call_fail_kind function is called incorrectly in the specialize_method_descriptor function.

I'd like to submit a PR to fix them and make them display correctly.

Linked PRs

Activity

  1. penguin-wwy
    added
    type-bugAn unexpected behavior, bug, or error
    on Nov 25, 2022

  2. penguin-wwy commented on Nov 25, 2022

    @penguin-wwy
    penguin-wwy
    on Nov 25, 2022
    ContributorAuthor

    @markshannon Can you please review this issue? Other instruction specializations also seem to have incorrect display fail_kind.

  3. markshannon
    added a commit that references this issue on Dec 22, 2022

    GH-99770: Make the correct call specialization fail kind show up in t…

    a021612
  4. penguin-wwy
    closed this as completedon Dec 23, 2022
  5. iritkatriel
    added a commit that references this issue on Dec 28, 2022

    Merged main into regmachine branch (#50)

    fdc73cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions