You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
re module: search() vs. match() section should mention fullmatch() #98906
Python offers two different primitive operations based on regular expressions: re.match() checks for a match only at the beginning of the string, while re.search() checks for a match anywhere in the string (this is what Perl does by default).
but there has been re.fullmatch() since Python 3.4. I believe the third method should be mentioned and should get its own examples as well.
changed the title [-]`re` module: `search() vs. match()` should should mention `fullmatch()`[/-][+]`re` module: `search() vs. match()` section should mention `fullmatch()`[/+]on Oct 31, 2022
Great that there's interest enhancing this! One thing to decide is should the section header be changed or not. Mentioning only search and match when there's also fullmatch would be odd, but the change would break possible internal and external links to this section. Internal links can be fixed as part of this change, though, and external ones can be preserved by adding an explicit link target with the old name. What approach has been used in this kind of situations earlier?
That said, a cross-reference between the two entries doesn't make sense. The entries are already adjacent to one another. And we don't want to get into the business of stylistic nudging by having one feature "advertise" another.
Instead, it would be better to beef up the examples to show off fullmatch. Also the text for match and fullmatch should be expanded to draw a distinction between the them. We already have verbiage about being different from a zero-length match. There should be further wording to highlight how match and fullmatch differ from one another.
Activity
[-]`re` module: `search() vs. match()` should should mention `fullmatch()`[/-][+]`re` module: `search() vs. match()` section should mention `fullmatch()`[/+]ericvsmith commentedon Oct 31, 2022
That seems like a good idea. Just this week I was looking at search vs. match, and completely forgot about fullmatch.
ramvikrams commentedon Oct 31, 2022
Can I add the
re.fullmatch()and it's examplesfor python#98906
pekkaklarck commentedon Nov 1, 2022
Great that there's interest enhancing this! One thing to decide is should the section header be changed or not. Mentioning only search and match when there's also fullmatch would be odd, but the change would break possible internal and external links to this section. Internal links can be fixed as part of this change, though, and external ones can be preserved by adding an explicit link target with the old name. What approach has been used in this kind of situations earlier?
akulakov commentedon Nov 1, 2022
I think it's fine to keep the section name, especially as fullmatch is a variant of
match().rhettinger commentedon Nov 5, 2022
+1
I would also like
fullmatchbecome better known.That said, a cross-reference between the two entries doesn't make sense. The entries are already adjacent to one another. And we don't want to get into the business of stylistic nudging by having one feature "advertise" another.
Instead, it would be better to beef up the examples to show off
fullmatch. Also the text formatchandfullmatchshould be expanded to draw a distinction between the them. We already have verbiage about being different from a zero-length match. There should be further wording to highlight howmatchandfullmatchdiffer from one another.GH-98906 ```re``` module: ```search() vs. match()``` section should m…
pythonGH-98906 ```re``` module: ```search() vs. match()``` section sh…
pythonGH-98906 ```re``` module: ```search() vs. match()``` section sh…
ericvsmith commentedon Nov 30, 2022
Thanks, @ramvikrams !
[3.11] GH-98906 ```re``` module: ```search() vs. match()``` section s…
[3.10] GH-98906 ```re``` module: ```search() vs. match()``` section s…
ramvikrams commentedon Dec 1, 2022
Thanks sir
Merge branch 'main' into fixinspect