Repository navigation
Consistent test failures in test test_asyncio.test_streams.test_drain_raises on Windows #98703
Description
Run python_d.exe -m test test_asyncio -m test_drain_raises -F on Windows. The test eventually fails after some repetitions.
The problem is that _call_connection_lost can be called multiple times, even after the socket by the proactortransport is closed. So it's calling close() on something that is already set to None.
I have a PR to fix it.
Metadata
Metadata
Assignees
Projects
- Status
Activity
Fidget-Spinner commentedon Oct 26, 2022
@pablogsal sorry to bother you right after the monumental 3.11 release (thanks for that by the way!). However, I'm setting this as release blocker as it's causing the Windows Buildbots to occasionally fail https://buildbot.python.org/all/#/builders/146.
I have already created a PR to fix this.
pablogsal commentedon Oct 26, 2022
Thanks a lot @Fidget-Spinner 🙏
gvanrossum commentedon Oct 26, 2022
Does it needs to be a release blocker? Or just be backported?
5 remaining items
gh-98703: Fix asyncio proactor_events calling _call_connection_lost m…
Fidget-Spinner commentedon Oct 27, 2022
Waiting for Kumar's tests to land before I close this issue. It's no longer a release blocker though.
gh-98703: Add tests for closing `_ProactorSocketTransport` with proac…
pythongh-98703: Add tests for closing `_ProactorSocketTransport` with…
pythongh-98703: Add tests for closing `_ProactorSocketTransport` with…
gh-98703: Add tests for closing `_ProactorSocketTransport` with proac…
gh-98703: Add tests for closing `_ProactorSocketTransport` with proac…
pythongh-98703: Fix asyncio proactor_events calling _call_connection_…
pythongh-98703: Add tests for closing `_ProactorSocketTransport` with…