Repository navigation
The term "typechecks" is confusingly used as an adjective #96130
Description
Activity
It's particular confusing in NewType https://docs.python.org/3.10/library/typing.html#newtype
The static type checker will treat the new type as if it were a subclass of the original type. This is useful in helping catch logical errors:
def get_user_name(user_id: UserId) -> str: ... # typechecks user_a = get_user_name(UserId(42351)) # does not typecheck; an int is not a UserId user_b = get_user_name(-1)
The last two line may mean, the type checker skips checking this line.
Do you have a proposal to improve this? I think it’s okay as-is, but if you can make it better that would be good.
I believe "Passes type checking" and "Fails type checking" is very clear.
I believe "Passes type checking" and "Fails type checking" is very clear.
Agreed!
- added a commit that references this issue
on Oct 10, 2022 - added a commit that references this issue
on Oct 12, 2022 Thanks @ketozhang for the report and @hauntsaninja for the fix!
Reacted by Keto D. Zhang- added 2 commits that reference this issue
on Oct 14, 2022
Documentation
Arguably to new eyes, you can mistaken "typecheck" to be a verb meaning "to do type checking". I understand this term came from the C function TypeCheck that returns a boolean.