You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Tweak asyncio.Runner loop_factory docs to emphasize that the default case *does* call set_event_loop() #96036
Whatever gives users the best guidance. I searched for code that uses Runner(loop_factory=...) and there is one case apart from test_runners.py: in test_asyncio/test_subprocess.py it is used as loop_factory=asyncio.new_event_loop specifically to prevent the watcher to be set (since the test sets its own watcher).
I would emphasize that the default case does call set_event_loop() and implies attaching the watcher (if there is one!) to the loop; it's fine to suggest that loop_factory should be used only if this is undesired.
changed the title [-]tweak asyncio.Runner loop_factory docs to emphasize that the default case *does* call `set_event_loop()`[/-][+]Tweak asyncio.Runner loop_factory docs to emphasize that the default case *does* call `set_event_loop()`[/+]on Aug 16, 2022
Are you still interested in working on rewording this to your liking? If not I am inclined to close this, for me the existing docs added by myself is sufficient.
Activity
[-]tweak asyncio.Runner loop_factory docs to emphasize that the default case *does* call `set_event_loop()`[/-][+]Tweak asyncio.Runner loop_factory docs to emphasize that the default case *does* call `set_event_loop()`[/+]kumaraditya303 commentedon Mar 19, 2023
Are you still interested in working on rewording this to your liking? If not I am inclined to close this, for me the existing docs added by myself is sufficient.