Skip to content

IsolatedAsyncioTestCase calls _setupAsyncioRunner even for skipped tests #96030

Closed
Closed
IsolatedAsyncioTestCase calls _setupAsyncioRunner even for skipped tests#96030
Labels
pendingThe issue will be closed if no feedback is providedtestsTests in the Lib/test dirtopic-asynciotype-bugAn unexpected behavior, bug, or error

Description

@tiran
tiran
opened on Aug 16, 2022

Bug report

TestCase.run() is always executed, even for skipped tests. In fact the method checks for skipped and expected failure markers. The implementation of IsolatedAsyncioTestCase.run runs additional code around TestCase.run that does not obey the skipped marker. This was first discovered when GH-95736 broke tests on wasm32-emscripten. _setupAsyncioRunner should not be called if a test method or class is marked as skipped.

I have an easy fix for the issue.

Activity

  1. tiran
    added
    type-bugAn unexpected behavior, bug, or error
    on Aug 16, 2022
  2. AlexWaygood
    added
    testsTests in the Lib/test dir
    topic-asyncio
    on Aug 16, 2022
  3. tiran
    added 2 commits that reference this issue on Aug 16, 2022

    pythongh-96030: IsolatedAsyncioTestCase: don't create asyncio runner …

    c56793a

    pythongh-96030: IsolatedAsyncioTestCase: don't create asyncio runner …

    c31d0e8

  4. gvanrossum commented on Aug 16, 2022

    @gvanrossum
    gvanrossum
    on Aug 16, 2022
    Member

    Maybe #96033 was meant to fix this too?

  5. gvanrossum
    changed the title [-]IsolatedAsyncioTestCase sets up asyncio runner for skipped tests[/-] [+]IsolatedAsyncioTestCase calls _setupAsyncioRunner even for skipped tests[/+] on Aug 16, 2022
  6. serhiy-storchaka
    added this to Unittest & doctest issueson Aug 20, 2022
  7. serhiy-storchaka
    moved this to Todo in Unittest & doctest issueson Aug 20, 2022

  8. kumaraditya303 commented on Oct 30, 2022

    @kumaraditya303
    kumaraditya303
    on Oct 30, 2022
    Contributor

    AFAIK this is already fixed by #96033.

  9. kumaraditya303
    added
    pendingThe issue will be closed if no feedback is provided
    on Oct 30, 2022
  10. ezio-melotti
    added this to asyncioon Oct 30, 2022
  11. ezio-melotti
    moved this to Todo in asyncioon Oct 30, 2022
  12. gvanrossum
    closed this as completedon Oct 30, 2022
  13. Repository owner moved this from Todo to Done in asyncioon Oct 30, 2022
  14. Repository owner moved this from Todo to Done in Unittest & doctest issueson Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    pendingThe issue will be closed if no feedback is providedtestsTests in the Lib/test dirtopic-asynciotype-bugAn unexpected behavior, bug, or error

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions