test_sys_settrace leaked [6604, 6602, 6604] on main branch  #94979

Activity

1. kumaraditya303

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   3.12only security fixesonly security fixes

   on Jul 18, 2022
2. kumaraditya303 commented on Jul 18, 2022

   

   kumaraditya303

   on Jul 18, 2022

   ContributorAuthor

   More actions

   cc @markshannon @pablogsal
3. kumaraditya303 commented on Jul 18, 2022

   

   kumaraditya303

   on Jul 18, 2022

   ContributorAuthor

   More actions

   Git bisect points to 2f8bff6 as first bad commit:

   commit 2f8bff6879c5d76d143068e8bc867196a7d28afc (HEAD)
   Author: Mark Shannon <mark@hotpy.org>
   Date:   Mon Jul 18 16:06:42 2022 +0100
   
       GH-94739: Mark stacks of exception handling blocks for setting frame.f_lineno in the debugger. (GH-94958)
   
4. kumaraditya303

   assigned

   markshannon

   on Jul 18, 2022
5. mdboom commented on Jul 18, 2022

   

   mdboom

   on Jul 18, 2022

   Contributor

   More actions

   frame.setlineno strikes again.
6. brandtbucher commented on Jul 18, 2022

   

   brandtbucher

   on Jul 18, 2022

   Member

   More actions

   Checking this out now.
7. brandtbucher commented on Jul 18, 2022

   

   brandtbucher

   on Jul 18, 2022

   Last edited by brandtbucher

   Member

   More actions

   The following three tests are leaking:

   • test_jump_from_except_to_finally
   • test_jump_out_of_bare_except_block
   • test_jump_out_of_qualified_except_block

   The issue is when we jump out of an exception handler into non-exception-handling code. We skip over POP_EXCEPT, which is supposed to clear tstate->exc_info->exc_value, the currently active exception. This exception references thousands of objects through its traceback frames.

   I'm not sure what a good solution is. Perhaps clearing the thread's exception state if we can detect that we're jumping out of an exception handler? I'm not sure if that's always correct (or even easy to detect). Maybe we can flag every stack between an exception handler entry and a POP_EXCEPT?

   Or, just disallow jumping out of exception handlers like this?
8. markshannon

   added 2 commits that reference this issue on Jul 19, 2022

   GH-94979: Pop the exception stack when jumping out of exception handl…

   ...

   3f73860

   pythonGH-94979: Pop the exception stack when jumping out of exception…

   ...

   28e2929
9. kumaraditya303

   closed this as completedon Jul 21, 2022