Skip to content

Remove unneeded module state from _json module #94393

Closed
#94394
Closed
Remove unneeded module state from _json module#94393
#94394
Labels
3.12only security fixesextension-modulesC modules in the Modules dirtype-featureA feature request or enhancement

Description

@erlend-aasland
erlend-aasland
opened on Jun 28, 2022

The _json module got multi-phase initialisation and heap types in GH-17835. However, there is no need for it to have module state. We can remove approx. 50 lines of code, and get rid of the unneeded state allocation.

Activity

  1. erlend-aasland
    added
    type-featureA feature request or enhancement
    extension-modulesC modules in the Modules dir
    on Jun 28, 2022
  2. erlend-aasland
    added a commit that references this issue on Jun 28, 2022

    pythongh-94393: Remove unneeded module state from _json

    1ec6f7a
  3. erlend-aasland
    linked a pull request that will close this issuegh-94393: Remove unneeded module state from _json #94394on Jun 28, 2022
  4. erlend-aasland
    added
    3.12only security fixes
    on Jun 28, 2022
  5. erlend-aasland
    closed this as completedin #94394on Jul 2, 2022
  6. erlend-aasland
    added a commit that references this issue on Jul 2, 2022

    gh-94393: Remove unneeded module state from _json (#94394)

    3a2e615
  7. serhiy-storchaka
    added this to JSON issueson Dec 15, 2022
  8. serhiy-storchaka
    moved this to Done in JSON issueson Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.12only security fixesextension-modulesC modules in the Modules dirtype-featureA feature request or enhancement

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions