You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Inconsistency in handling None handlers in the Python and C implementations of pickle #93627
In the Python implementation of pickle setting some handlers to None causes a fallback to other methods.
Setting Pickler.reducer_override to None has the same effect as not setting this attribute -- falling back to other methods.
Setting the dispatch_table to None leads to falling back to __reduce_ex__.
Setting the __reduce_ex__ attribute to None leads to falling back to __reduce__.
Setting the __setstate__ attribute to None leads to falling back to the default implementation of __setstate__ (setting __dict__ and slots).
In the C implementation all this leads to TypeError: 'NoneType' object is not callable.
The copy module follows the Python implementation of pickle, except that it fails for any false value of __reduce__, not just None.
In most other code setting a dunder method to None leads to a TypeError (either raise explicitly or just generic "'NoneType' object is not callable").
We should decide what behavior should be in the pickle and copy module. On one hand, the Python implementation was primary. On other hand, it was inconsistent between the pickle and copy modules and was already changed in the past, the C implementation of pickle is now used by most users, and it is more consistent with other code.
@serhiy-storchaka How can we move forward with this issue? Adapting the different components is something I can help out with, but I do not have sufficient experience to make an informed decision on which behavior is desired and whether we can make backwards incompatible changes.
Activity
eendebakpt commentedon Mar 22, 2023
@serhiy-storchaka How can we move forward with this issue? Adapting the different components is something I can help out with, but I do not have sufficient experience to make an informed decision on which behavior is desired and whether we can make backwards incompatible changes.
gh-93627: Align Python implementation of pickle with C implementation…