Repository navigation
Argparse choices should be a sequence #92446
Description
Activity
- added a commit that references this issue
on May 13, 2022 Actually, the linked pr changes refer to
lzmainstead ofargparse, was this intended?Reacted by ShantanuOn a quick review I'd also say that the change to
lzma.rstshould be reverted, as the option is in the context of.xzor.lzmacontainer formats.A
Reacted by Ulises Ojeda- added 5 commits that reference this issue
on Dec 26, 2022 - added a commit that references this issue
on Dec 26, 2022 - added a commit that references this issue
on Dec 28, 2022
Documentation
Instead of saying "any container" is supported, refer only to "sequences".
Technically, a Container is only required to support
__contains__which is insufficent for argparse. Also, a sets do get accepted are a bad choice because the order shown in help and usage is non-deterministic. So, Sequence is the only reasonable choice because we need sizing and ordered iteration.Linked PRs