Repository navigation
test_zlib: test_pair() and test_speech128() fail with s390x hardware accelerator #90781
Description
| BPO | 46623 |
|---|---|
| Nosy | @vstinner, @encukou |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2022-02-03.08:34:40.152>
labels = ['tests', '3.9', '3.10', '3.11']
title = 'test_zlib: test_pair() and test_speech128() fail with s390x hardware accelerator'
updated_at = <Date 2022-03-03.13:20:48.694>
user = 'https://github.com/vstinner'bugs.python.org fields:
activity = <Date 2022-03-03.13:20:48.694>
actor = 'petr.viktorin'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2022-02-03.08:34:40.152>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 46623
keywords = ['patch']
message_count = 6.0
messages = ['412426', '413866', '413939', '413940', '413941', '414437']
nosy_count = 2.0
nosy_names = ['vstinner', 'petr.viktorin']
pr_nums = ['31096']
priority = 'normal'
resolution = None
stage = 'resolved'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue46623'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
Activity
vstinner commentedon Feb 3, 2022
test_pair() and test_speech128() tests of test_zlib fail on the s390x architecture if zlib uses the s390x hardware accelerator.
RHEL8 downstream issues (with most details):
https://bugzilla.redhat.com/show_bug.cgi?id=1974658
Fedora downstream issues:
https://bugzilla.redhat.com/show_bug.cgi?id=2038848
The s390x has a hardware accelerator for zlib. Depending if the hardware accelerator is used or not, the output (compress data) is different.
Also, test_zlib compress data in two different ways and then expect the same output. test_zlib pass with the software implementation which creates a single (final) compressed block. test_zlib fails with the hardware implementation which creates multiple compressed blocks (the last one is a final block).
Another reason the output differs is the FHT/DHT heuristic. The zlib deflate algorithm can analyze the data distribution and decide whether it wants to use a fixed-Huffman table (FHT) or a dynamic-Huffman table (DHT) for the next block, but the accelerator can't. Furthermore, looking at data in software would kill the accelerator performance. Therefore the following heuristic is used on s390x: the first 4k are compressed with FHT and the rest of the data with DHT. So, compress() creates a single FHT block. compressobj() creates a FHT block, a DHT block and a trailing block.
It is *not a bug* in zlib: the decompression gives back the original content as expected in all cases. The issue is that Python test_zlib makes too many assumptions on how "streamed" data should be compressed. The test expected that compressed data using different ways to call zlib would return the exact same compressed data. If an accelarator is used, it's not always the case.
vstinner commentedon Feb 23, 2022
I checked os.uname() value on two buildbots, by looking at their test.pythoninfo:
os.uname: posix.uname_result(sysname='Linux', nodename='ztcpip3.pok.ibm.com', release='3.10.0-1160.53.1.el7.s390x', version='#1 SMP Thu Dec 16 04:33:52 EST 2021', machine='s390x')
os.uname: posix.uname_result(sysname='Linux', nodename='dje', release='5.10.0-11-s390x', version='#1 SMP Debian 5.10.92-1 (2022-01-18)', machine='s390x')
So the machine is 's390x'.
vstinner commentedon Feb 24, 2022
New changeset 9475dc0 by Victor Stinner in branch 'main':
bpo-46623: Skip two test_zlib tests on s390x (GH-31096)
9475dc0
vstinner commentedon Feb 24, 2022
Even if Python 3.9 and 3.10 are also affected, I prefer to not backport the change since it's not ideal.
vstinner commentedon Feb 24, 2022
The Python 3.7 package on Fedora also skips these two tests using --ignore option of regrtest:
7 remaining items
skip two test_zlib tests failing on s390x
skip two test_zlib tests failing on s390x
skip two test_zlib tests failing on s390x
skip two test_zlib tests failing on s390x
skip two test_zlib tests failing on s390x
skip two test_zlib tests failing on s390x
skip two test_zlib tests failing on s390x
skip two test_zlib tests failing on s390x
skip two test_zlib tests failing on s390x
pythongh-125041: pythongh-90781: test_zlib: For s390x HW acceleration…
[3.9] pythongh-125041: pythongh-90781: test_zlib: For s390x HW accele…
[3.10] gh-125041: gh-90781: test_zlib: For s390x HW acceleration, ski…
[3.9] gh-125041: gh-90781: test_zlib: For s390x HW acceleration, skip…
skip two tests failing on s390x