Repository navigation
[sqlite3] don't combine error checks when adding integer constants #89797
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2021-10-31.17:22:04.676>
created_at = <Date 2021-10-27.21:02:56.704>
labels = ['extension-modules', '3.10', '3.11']
title = "[sqlite3] don't combine error checks when adding integer constants"
updated_at = <Date 2021-10-31.17:22:04.675>
user = 'https://github.com/erlend-aasland'bugs.python.org fields:
activity = <Date 2021-10-31.17:22:04.675>
actor = 'erlendaasland'
assignee = 'none'
closed = True
closed_date = <Date 2021-10-31.17:22:04.676>
closer = 'erlendaasland'
components = ['Extension Modules']
creation = <Date 2021-10-27.21:02:56.704>
creator = 'erlendaasland'
dependencies = []
files = []
hgrepos = []
issue_num = 45634
keywords = ['patch']
message_count = 4.0
messages = ['405124', '405396', '405400', '405409']
nosy_count = 2.0
nosy_names = ['corona10', 'erlendaasland']
pr_nums = ['29251', '29343']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue45634'
versions = ['Python 3.10', 'Python 3.11']
Activity
erlend-aasland commentedon Oct 27, 2021
In Modules/_sqlite/module.c, add_integer_constants() accumulates the return values of repeated PyModule_AddIntMacro() calls. We should change this to instead bailing immediately on error.
corona10 commentedon Oct 31, 2021
New changeset 39b4d59 by Erlend Egeberg Aasland in branch 'main':
bpo-45634: Don't combine error checks when adding
sqlite3int constants (GH-29251)39b4d59
corona10 commentedon Oct 31, 2021
New changeset ed91f95 by Erlend Egeberg Aasland in branch '3.10':
[3.10] bpo-45634: Don't combine error checks when adding
sqlite3int constants (GH-29251). (GH-29343)ed91f95
erlend-aasland commentedon Oct 31, 2021
Thanks for reviewing, Dong-hee!