Repository navigation
[sqlite3] cleanup callbacks (GIL handling, naming, ...) #89154
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/erlend-aasland'
closed_at = <Date 2021-09-07.13:06:38.494>
created_at = <Date 2021-08-24.13:07:12.425>
labels = ['extension-modules', 'type-feature']
title = '[sqlite3] cleanup callbacks (GIL handling, naming, ...)'
updated_at = <Date 2021-10-12.11:39:20.178>
user = 'https://github.com/erlend-aasland'bugs.python.org fields:
activity = <Date 2021-10-12.11:39:20.178>
actor = 'petr.viktorin'
assignee = 'erlendaasland'
closed = True
closed_date = <Date 2021-09-07.13:06:38.494>
closer = 'petr.viktorin'
components = ['Extension Modules']
creation = <Date 2021-08-24.13:07:12.425>
creator = 'erlendaasland'
dependencies = []
files = []
hgrepos = []
issue_num = 44991
keywords = ['patch']
message_count = 9.0
messages = ['400207', '400225', '400265', '400267', '400269', '400722', '401246', '401247', '403726']
nosy_count = 4.0
nosy_names = ['petr.viktorin', 'corona10', 'miss-islington', 'erlendaasland']
pr_nums = ['27934', '28088', '28209']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue44991'
versions = []
Activity
erlend-aasland commentedon Aug 24, 2021
Quoting msg400205 by Petr in bpo-42064:
I think the module could use a more comprehensive review for GIL handling, rather than doing it piecewise in individual PRs. I recommend that any function passed to SQLite (and only those) should
*_callback, for clarityerlend-aasland commentedon Aug 24, 2021
I'd like to propose further enhancements:
If you agree, I'll create separate PR's for those; one for each refactor. I think it will enhance readability a lot.
[-][sqlite3] cleanup GIL handling[/-][+][sqlite3] cleanup callbacks (GIL handling, naming, ...)[/+][-][sqlite3] cleanup GIL handling[/-][+][sqlite3] cleanup callbacks (GIL handling, naming, ...)[/+]encukou commentedon Aug 25, 2021
The general policy is to only improve style for code you touch for some other reasons. You're changing lots of the callback code in bpo-42064, so I reckon making things more readable is fine.
corona10 commentedon Aug 25, 2021
Obviously, this case could be code churn(we don't accept normally), but if other core-dev agree with the changes. I am fine.
erlend-aasland commentedon Aug 25, 2021
We'll do the changes Petr proposed first, and then I'll see how invasive the other changes will be. If the diffs end up being concise, I'll put them up for review :)
miss-islington commentedon Aug 31, 2021
New changeset 001ef46 by Erlend Egeberg Aasland in branch 'main':
bpo-44991: Make GIL handling more explicit in
sqlite3callbacks (GH-27934)001ef46
encukou commentedon Sep 7, 2021
New changeset 0474d06 by Erlend Egeberg Aasland in branch 'main':
bpo-44991: Normalise
sqlite3callback naming (GH-28088)0474d06
encukou commentedon Sep 7, 2021
The remaining function_pinboard_* renames are part of PR-27940.
encukou commentedon Oct 12, 2021
New changeset cfb1df3 by Erlend Egeberg Aasland in branch 'main':
bpo-44991: Normalise function and collation callback naming (GH-28209)
cfb1df3