You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Stored (uncompressed) ZipExtFile in zipfile can be seekable at lower cost #88339
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee='https://github.com/gpshead'closed_at=Nonecreated_at=<Date2021-05-19.02:28:39.857>labels= ['type-feature', 'library', '3.11']
title='Stored (uncompressed) ZipExtFile in zipfile can be seekable at lower cost'updated_at=<Date2021-08-18.17:30:30.110>user='https://github.com/JuniorJPDJ'
At the moment stored ZipExtFile is being read to the place of seek like all other compressed variants.
It's not needed as it's possible to freely seek uncompressed file inside zip without this penalty.
Lots of apps depend on ZipExtFile seeking ability and it would lower performance and IO penalty significantly.
I've POC patch created.
It disables CRC checking after first seek as it's impossible to check CRC if we are not reading whole file.
Activity
JuniorJPDJ commentedon May 19, 2021
At the moment stored ZipExtFile is being read to the place of seek like all other compressed variants.
It's not needed as it's possible to freely seek uncompressed file inside zip without this penalty.
Lots of apps depend on ZipExtFile seeking ability and it would lower performance and IO penalty significantly.
I've POC patch created.
It disables CRC checking after first seek as it's impossible to check CRC if we are not reading whole file.
gh-88339: enable fast seeking of uncompressed unencrypted zipfile.Zip…
gpshead commentedon Aug 6, 2022
merged for 3.12. thanks for the contribution!
pythongh-88339: enable fast seeking of uncompressed unencrypted zipfi…